Details

Reviewers

bartek
kamil
ashoat

Commits

rCOMMb2207bb46a6b: [lib] Show an alert before disconnecting from Farcaster

Summary

Show an alert so that the user is warned about the consequences.

https://linear.app/comm/issue/ENG-11170/handle-user-data-when-disconnecting-farcaster-account

Test Plan

Click disconnect to test if the alert appears. Check if confirming and canceling works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 27 2025, 11:53 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2025, 11:53 AM

tomek added a reviewer: ashoat.Aug 27 2025, 11:54 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 27 2025, 11:55 AM

Harbormaster failed remote builds in B35544: Diff 50025!

tomek added a child revision: D15242: [lib] Clear Farcaster threads on disconnect.Aug 27 2025, 11:56 AM

tomek requested review of this revision.Aug 27 2025, 11:57 AM

Not sure if this is intended after this diff, potential exceptions from unlink are swallowed and not presented to the user, example is here

Error handling

Harbormaster failed remote builds in B35569: Diff 50053!Aug 28 2025, 10:39 AM

kamil accepted this revision.Aug 28 2025, 10:51 AM

This revision is now accepted and ready to land.Aug 28 2025, 10:51 AM

This revision was landed with ongoing or failed builds.Aug 28 2025, 10:54 AM

Closed by commit rCOMMb2207bb46a6b: [lib] Show an alert before disconnecting from Farcaster. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb2207bb46a6b: [lib] Show an alert before disconnecting from Farcaster.

[lib] Show an alert before disconnecting from Farcaster
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50055

lib/utils/config.js

native/config.js

native/profile/farcaster-account-settings.react.js

[lib] Show an alert before disconnecting from FarcasterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50055

lib/utils/config.js

native/config.js

native/profile/farcaster-account-settings.react.js

[lib] Show an alert before disconnecting from Farcaster
ClosedPublic
Actions

Revision Contents
Changeset List