[lib] Clear Farcaster threads on disconnect
ClosedPublic
Actions

Authored by tomek on Aug 27 2025, 11:56 AM.

Details

Reviewers

bartek
kamil

Commits

rCOMM87a3e05b5e96: [lib] Clear Farcaster threads on disconnect

Summary

Delete the threads when a user disconnects from Farcaster.

Depends on D15241

https://linear.app/comm/issue/ENG-11170/handle-user-data-when-disconnecting-farcaster-account

Test Plan

Disconnect and check if the threads disappear.

Also checked if the messages were removed from the DB by modifying the message reducer to log all the thread ID from client DB messages, then opening the app to see if the Farcaster IDs were there, then disconnecting and reopening the app again - the Farcaster IDs disappeared.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 27 2025, 11:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2025, 11:56 AM

tomek published this revision for review.Aug 27 2025, 11:57 AM

Harbormaster failed remote builds in B35545: Diff 50026!Aug 27 2025, 11:59 AM

tomek added a child revision: D15250: [lib] Sync Farcaster threads after connection.Aug 27 2025, 12:57 PM

Messages should disappear too, but I would check it in the test plan

This revision is now accepted and ready to land.Aug 27 2025, 3:57 PM

In D15242#420253, @kamil wrote:

Messages should disappear too, but I would check it in the test plan

Updated the test plan.

Rebase

tomek added inline comments.Aug 28 2025, 10:34 AM

lib/utils/farcaster-utils.js
202 ↗	(On Diff #50054)	This will be also called when Neynar detects that the FID is invalid - we should discuss whether we should clear the threads also then. Tracked in https://linear.app/comm/issue/ENG-11187/decide-if-we-need-to-clear-the-threads-for-invalid-fids.