Details
Details
Tested later in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 451–453 ↗ | (On Diff #50134) | This is not handling ETH and Farcaster users correctly. Spoke with @bartek Today, and it will be faster if he works on it as having some context on how it might work and having some code drafted. Note that this name can't be longer than 32 characters |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 451–453 ↗ | (On Diff #50134) | I'll fix it later, now you can add substr(32) just to meet the condition blah.join(', ').substring(0, 32); |
| 457 ↗ | (On Diff #50134) | We should do something like this to support non-Comm users from Farcaster. Given their userID is formatted FID#111111, this util will extract correct FID, or null otherwise so it should work out of the box |