Details

Reviewers

kamil
bartek

Commits

rCOMM4ff037574170: [lib] Improve Farcaster sync performance

Summary

Reduce the number of dispatches by grouping data together. Introduce request retries.

https://linear.app/comm/issue/ENG-11212/add-a-loading-screen-while-fetching-farcaster-threads-for-the-first

Depends on D15298

Test Plan

Check if all the data is fetched correctly.
With the D15298 measure the performance (ask chat to create performance logs). In my test case, this reduces the processing time from 60s to about 6s, while keeping the app responsive.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 5 2025, 10:47 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2025, 10:47 AM

tomek added inline comments.Sep 5 2025, 10:52 AM

lib/shared/farcaster/farcaster-hooks.js
136 ↗	(On Diff #50180)	This helps with the responsivenes of the UI

Harbormaster completed remote builds in B35642: Diff 50180.Sep 5 2025, 11:06 AM

tomek requested review of this revision.Sep 5 2025, 11:06 AM

kamil accepted this revision.Sep 5 2025, 2:17 PM

kamil added inline comments.

lib/shared/farcaster/farcaster-hooks.js
37–42 ↗	(On Diff #50180)	Looking at the code below, I would probably implement this as a class: No need to define the initial object multiple times; the constructor can do it Having a method to get the Redux payload from an object
136 ↗	(On Diff #50180)	I would add a code coment, as this is something non-obvious
313–330 ↗	(On Diff #50180)	I would extract this to something like `getReduxPayloadFromBatchedUpdates` to reduce code duplication