Details

Reviewers

kamil
bartek

Commits

rCOMM492885d8609e: [native][web] Show a loading screen when initially fetching the Farcaster…

Summary

Introduce a loading screen that is shown both on native and web while the Farcaster sync is in progress
Stop fetching threads when opening the app
Modify conversation fetching logic so that the result can be awaited
Move responsibility of starting the sync to the loading screens

Screenshot 2025-09-08 at 19.01.32.png (1×1 px, 126 KB)

https://linear.app/comm/issue/ENG-11212/add-a-loading-screen-while-fetching-farcaster-threads-for-the-first

Depends on D15299

Test Plan

Checked on both native and web if the loading screens are visible for the duration of the sync

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 8 2025, 5:14 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 8 2025, 5:14 PM

tomek edited the summary of this revision. (Show Details)Sep 8 2025, 5:15 PM

tomek edited the summary of this revision. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 8 2025, 5:30 PM

Harbormaster failed remote builds in B35652: Diff 50197!

Rebase

Harbormaster completed remote builds in B35654: Diff 50199.Sep 9 2025, 9:10 AM

tomek requested review of this revision.Sep 9 2025, 9:10 AM

tomek added a child revision: D15309: [lib] Improve Farcaster sync loading state.Sep 9 2025, 2:07 PM

This needs to be rebased on D15305, which could require some more changes

native/farcaster/farcaster-sync-loading-screen.react.js
33 ↗	(On Diff #50199)	In case of Farcaster, shouldn't we use `conversations` instead of `threads`?
web/farcaster/farcaster-sync-loading-screen.css
11 ↗	(On Diff #50199)	This is scary, but probably it is fine

This revision is now accepted and ready to land.Sep 11 2025, 10:01 AM

Rebase and update the copy

native/farcaster/farcaster-sync-loading-screen.react.js
33 ↗	(On Diff #50199)	Makes sense!
web/farcaster/farcaster-sync-loading-screen.css
11 ↗	(On Diff #50199)	Anything sufficiently big should work

Harbormaster failed remote builds in B35687: Diff 50240!Sep 11 2025, 12:53 PM

Fix eslint

Harbormaster failed remote builds in B35691: Diff 50244!Sep 11 2025, 1:26 PM

This revision was landed with ongoing or failed builds.Sep 11 2025, 2:00 PM

Closed by commit rCOMM492885d8609e: [native][web] Show a loading screen when initially fetching the Farcaster…. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM492885d8609e: [native][web] Show a loading screen when initially fetching the Farcaster….

[native][web] Show a loading screen when initially fetching the Farcaster threads
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50240

lib/components/farcaster-data-handler.react.js

lib/shared/farcaster/farcaster-hooks.js

lib/tunnelbroker/use-peer-to-peer-message-handler.js

lib/utils/farcaster-utils.js

native/components/farcaster-sync-handler.react.js

native/farcaster/farcaster-sync-loading-screen.react.js

native/navigation/root-navigator.react.js

native/navigation/route-names.js

native/profile/profile-screen.react.js

native/root.react.js

web/app.react.js

web/components/farcaster-sync-overlay.react.js

web/farcaster/farcaster-sync-loading-screen.css

web/farcaster/farcaster-sync-loading-screen.react.js

web/settings/account-settings.react.js

[native][web] Show a loading screen when initially fetching the Farcaster threadsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50240

lib/components/farcaster-data-handler.react.js

lib/shared/farcaster/farcaster-hooks.js

lib/tunnelbroker/use-peer-to-peer-message-handler.js

lib/utils/farcaster-utils.js

native/components/farcaster-sync-handler.react.js

native/farcaster/farcaster-sync-loading-screen.react.js

native/navigation/root-navigator.react.js

native/navigation/route-names.js

native/profile/profile-screen.react.js

native/root.react.js

web/app.react.js

web/components/farcaster-sync-overlay.react.js

web/farcaster/farcaster-sync-loading-screen.css

web/farcaster/farcaster-sync-loading-screen.react.js

web/settings/account-settings.react.js

[native][web] Show a loading screen when initially fetching the Farcaster threads
ClosedPublic
Actions

Revision Contents
Changeset List