Paths

Table of Contentst

Differential D15325

[lib] Support image captions in FC threads
ClosedPublic
Actions

Authored by bartek on Sep 11 2025, 9:03 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM1a2ba00a9172: [lib] Support image captions in FC threads

Summary

Farcaster supports it, we can display them too as a separate message

Depends on D15324

Test Plan

Sent a Farcaster media with caption. On Comm app, it's displayed as a separate message.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 11 2025, 9:03 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 11 2025, 9:03 AM

bartek added a child revision: D15326: [lib] Support ThumbHash for Farcaster media.Sep 11 2025, 9:06 AM

Harbormaster failed remote builds in B35680: Diff 50232!Sep 11 2025, 9:18 AM

bartek published this revision for review.Sep 11 2025, 10:01 AM

bartek added inline comments.

lib/utils/convert-farcaster-message-to-comm-messages.js
60 ↗	(On Diff #50232)	Replaced `Media` with a more specific `Image` to make `uri` non-nullable
81 ↗	(On Diff #50232)	Not sure if this is okay and if we have any specific conventions / constraints for message IDs

tomek accepted this revision.Sep 12 2025, 11:59 AM

tomek added inline comments.

lib/utils/convert-farcaster-message-to-comm-messages.js
81 ↗	(On Diff #50232)	Whatever deterministic should work. We usually use `/` to split parts of the IDs, e.g. in `createChangeSettingsMessageDatasAndUpdate`.

This revision is now accepted and ready to land.Sep 12 2025, 11:59 AM

Rebase, follow ID convention

Harbormaster failed remote builds in B35715: Diff 50283!Sep 13 2025, 1:59 PM

This revision was landed with ongoing or failed builds.Sep 13 2025, 4:07 PM

Closed by commit rCOMM1a2ba00a9172: [lib] Support image captions in FC threads. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM1a2ba00a9172: [lib] Support image captions in FC threads.

Revision Contents
Changeset List

Path

Size

lib/

utils/

blob-service.js

7 lines

convert-farcaster-message-to-comm-messages.js

48 lines

Diff 50291

lib/utils/blob-service.js

Loading...

lib/utils/convert-farcaster-message-to-comm-messages.js

Loading...