Page MenuHomePhabricator

[CommCoreModule] Call `onopen` and `onclose` callback from `ClientGetReadReactor`
ClosedPublic

Authored by atul on Feb 7 2022, 6:17 AM.
Tags
None
Referenced Files
F3638480: D3123.diff
Fri, Jan 3, 8:07 PM
Unknown Object (File)
Thu, Jan 2, 9:11 AM
Unknown Object (File)
Thu, Jan 2, 9:11 AM
Unknown Object (File)
Thu, Jan 2, 9:11 AM
Unknown Object (File)
Thu, Jan 2, 9:11 AM
Unknown Object (File)
Thu, Jan 2, 8:59 AM
Unknown Object (File)
Thu, Jan 2, 1:50 AM
Unknown Object (File)
Fri, Dec 27, 2:32 AM

Details

Summary

Execute (well queue up on JS event thread) the onopen callback when the OnReadInitialMetadataDone lifecycle event is hit by gRPC. Do the same for onclose callback when the OnDone lifecycle event is hit.

Test Plan
  1. Call openSocket
  2. Assign .onopen callback
  3. Assign .onclose callback
  4. Make sure .onopen callback fires (console log something)
  5. Call socket.close()
  6. Make sure the .onclose callback fires (console log something)

f077.png (260×660 px, 50 KB)

Diff Detail

Repository
rCOMM Comm
Branch
landfeb4 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Feb 7 2022, 6:21 AM
atul retitled this revision from [CommCoreModule] Call `onopen` and `onclose` callback from `ClientGetReadRtr` to [CommCoreModule] Call `onopen` and `onclose` callback from `ClientGetReadReactor`.Feb 7 2022, 6:59 AM
This revision is now accepted and ready to land.Feb 7 2022, 7:17 AM
This revision now requires review to proceed.Feb 7 2022, 7:17 AM
ashoat added a reviewer: jim.
This revision is now accepted and ready to land.Feb 7 2022, 7:09 PM
This revision was landed with ongoing or failed builds.Feb 8 2022, 5:11 AM
This revision was automatically updated to reflect the committed changes.