Page MenuHomePhabricator
Differential D3348

[server] Move fetchMessageInfosSince's currentAsOf param to MessageSelectionCriteria
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:36 AM
Unknown Object (File)
Sat, Nov 2, 8:31 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM
View All Files
Subscribers
• adrian
• benschac
• karol

Details

Reviewers
tomek
atul
Commits
rCOMM368bc5c0c953: [server] Move fetchMessageInfosSince's currentAsOf param to…
Summary

Instead of having this param passed in separately, this diff combines it into MessageSelectionCriteria. The reason for this is that we want to allow fetchMessageInfos to filter in this way too.

Depends On D3347

Test Plan

I tested fetchMessageInfosSince (socket connect) and fetchMessageInfos (log in, scrolling to fetch older messages)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 6 2022, 3:43 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 3:43 PM
ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 3:44 PM
ashoat added a child revision: D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 3:48 PM
ashoat edited the summary of this revision. (Show Details)
ashoat added a parent revision: D3347: [server] Rename ThreadSelectionCriteria to MessageSelectionCriteria.
Harbormaster completed remote builds in B7167: Diff 10093.Mar 6 2022, 3:50 PM
ashoat requested review of this revision.Mar 6 2022, 3:50 PM
tomek accepted this revision.Mar 8 2022, 6:40 AM
This revision is now accepted and ready to land.Mar 8 2022, 6:40 AM
Herald added a subscriber: • benschac. · View Herald TranscriptMar 8 2022, 6:40 AM
ashoat updated this revision to Diff 10144.Mar 8 2022, 7:45 AM

Rebase

Harbormaster completed remote builds in B7214: Diff 10144.Mar 8 2022, 7:53 AM
Closed by commit rCOMM368bc5c0c953: [server] Move fetchMessageInfosSince's currentAsOf param to… (authored by ashoat). · Explain WhyMar 8 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM368bc5c0c953: [server] Move fetchMessageInfosSince's currentAsOf param to….

Revision Contents
Changeset List

PathSize
lib/
types/
1 line
server/
src/
fetchers/
31 lines
socket/
7 lines

Diff 10093

View Options

lib/types/message-types.js

Loading...
View Options

server/src/fetchers/message-fetchers.js

Loading...
View Options

server/src/socket/socket.js

Loading...