Page MenuHomePhabricator

[server] Move fetchMessageInfosSince's currentAsOf param to MessageSelectionCriteria
ClosedPublic

Authored by ashoat on Mar 6 2022, 3:43 PM.
Tags
None
Referenced Files
F3299493: D3348.diff
Sun, Nov 17, 12:42 PM
Unknown Object (File)
Wed, Nov 6, 11:36 AM
Unknown Object (File)
Sat, Nov 2, 8:31 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM

Details

Summary

Instead of having this param passed in separately, this diff combines it into MessageSelectionCriteria. The reason for this is that we want to allow fetchMessageInfos to filter in this way too.

Depends On D3347

Test Plan

I tested fetchMessageInfosSince (socket connect) and fetchMessageInfos (log in, scrolling to fetch older messages)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Mar 6 2022, 3:50 PM
This revision is now accepted and ready to land.Mar 8 2022, 6:40 AM