[server] Make time filter check less brittle in fetchMessageInfos
ClosedPublic
Actions

Authored by ashoat on Mar 14 2022, 12:49 PM.

Details

Reviewers

tomek
atul

Commits

rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos

Summary

This diff is a follow-up to @palys-swm's comment in D3410.

Test Plan

I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
I made sure all threads loaded all the way to the start of a thread if I kept scrolling

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/less-brittle-time-filter-conditions

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 14 2022, 12:49 PM

Herald added subscribers: • benschac, • karol, • adrian. · View Herald TranscriptMar 14 2022, 12:49 PM

ashoat mentioned this in D3410: [server] Don't set EXHAUSTIVE when there is a time filter.Mar 14 2022, 12:49 PM

Harbormaster completed remote builds in B7362: Diff 10366.Mar 14 2022, 12:59 PM

ashoat requested review of this revision.Mar 14 2022, 12:59 PM

Looks great! Agree, this is a lot better approach than the simple invariant I proposed in D3410

This revision is now accepted and ready to land.Mar 15 2022, 3:14 AM

Closed by commit rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos (authored by ashoat). · Explain WhyMar 15 2022, 7:47 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos.

Revision Contents
Changeset List

Path

Size

server/

src/

fetchers/

message-fetchers.js

101 lines

Diff 10366

View Options

server/src/fetchers/message-fetchers.js

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines	class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override;		jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;		jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object		jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;		openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override;		double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value		jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;		setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override;		jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
		void clearSensitiveData(jsi::Runtime &rt) override;

public:		public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);		CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);

void initializeNetworkModule(		void initializeNetworkModule(
const std::string &userId,		const std::string &userId,
const std::string &deviceToken,		const std::string &deviceToken,
const std::string &hostname = "");		const std::string &hostname = "");
};		};

} // namespace comm		} // namespace comm

[server] Make time filter check less brittle in fetchMessageInfosClosedPublicActions