Page MenuHomePhabricator

[server] Make time filter check less brittle in fetchMessageInfos
ClosedPublic

Authored by ashoat on Mar 14 2022, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:41 PM
Unknown Object (File)
Sat, Nov 2, 8:31 AM
Unknown Object (File)
Oct 7 2024, 6:39 AM
Unknown Object (File)
Oct 7 2024, 6:39 AM
Unknown Object (File)
Oct 7 2024, 6:38 AM
Unknown Object (File)
Oct 7 2024, 6:34 AM
Unknown Object (File)
Oct 4 2024, 10:37 AM
Unknown Object (File)
Sep 24 2024, 7:17 AM

Details

Summary

This diff is a follow-up to @palys-swm's comment in D3410.

Test Plan
  1. I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
  2. I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
  3. I made sure all threads loaded all the way to the start of a thread if I kept scrolling

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable