This diff is a follow-up to @palys-swm's comment in D3410.
Details
Details
- I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
- I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
- I made sure all threads loaded all the way to the start of a thread if I kept scrolling
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks great! Agree, this is a lot better approach than the simple invariant I proposed in D3410