Page MenuHomePhabricator
Differential D3447

[web] Remove "Request Access" markup/styling from `Splash` component
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 10:10 PM
Unknown Object (File)
Wed, Jul 3, 9:24 PM
Unknown Object (File)
Tue, Jul 2, 3:25 AM
Unknown Object (File)
Sat, Jun 29, 9:49 PM
Unknown Object (File)
Fri, Jun 21, 11:59 PM
Unknown Object (File)
Fri, Jun 21, 11:59 PM
Unknown Object (File)
Fri, Jun 21, 11:59 PM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
View All Files
Subscribers
• adrian
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMMc1e73f7b9e95: [web] Remove "Request Access" markup/styling from `Splash` component
Summary

Remove all JSX/CSS related to legacy "Request Access" functionality from the Splash component.

Note: There's still stray functionality/types/etc. in other files which will be dealt with in a separate diff. This diff focuses exclusively on splash.react.js and splash.css.

depends on D3446

Test Plan

The only thing we really care about keeping around is the LogInModal.

  1. Click "Log in" in the header
  2. Enter credentials
  3. Make sure user is properly authenticated and redirected to web app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 16 2022, 3:02 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 16 2022, 3:02 PM
atul published this revision for review.Mar 16 2022, 3:04 PM
atul mentioned this in D3448: [web] Remove `div.bottomContainer` from `Splash`.Mar 16 2022, 3:09 PM
Harbormaster completed remote builds in B7433: Diff 10463.Mar 16 2022, 3:09 PM
atul mentioned this in D3449: [web] Remove `div.content` from `Splash`.Mar 16 2022, 3:17 PM
atul mentioned this in D3450: [web] Remove everything from `Splash` except Log in button.Mar 16 2022, 3:31 PM
• benschac accepted this revision.Mar 16 2022, 5:29 PM
This revision is now accepted and ready to land.Mar 16 2022, 5:29 PM
atul edited the summary of this revision. (Show Details)Mar 16 2022, 9:11 PM
atul added a parent revision: D3446: [web] Remove `background.png` from `Splash` and rename to `placeholder.png`.
atul added a child revision: D3448: [web] Remove `div.bottomContainer` from `Splash`.
atul added 1 blocking reviewer(s): tomek.Mar 16 2022, 9:46 PM
This revision now requires review to proceed.Mar 16 2022, 9:46 PM
atul changed 2 blocking reviewer(s), added 1: ashoat; removed 1: tomek.Mar 17 2022, 8:12 AM
tomek accepted this revision.Mar 17 2022, 10:37 AM

Red diff - great!
By the way, not sure what happened here: this diff was accepted by Ben, but is still present in my queue, which is really nice!

atul removed a reviewer: ashoat.Mar 17 2022, 10:58 AM
This revision is now accepted and ready to land.Mar 17 2022, 10:58 AM
atul updated this revision to Diff 10482.Mar 17 2022, 11:00 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 17 2022, 11:00 AM
Closed by commit rCOMMc1e73f7b9e95: [web] Remove "Request Access" markup/styling from `Splash` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc1e73f7b9e95: [web] Remove "Request Access" markup/styling from `Splash` component.
Harbormaster failed remote builds in B7445: Diff 10482!Mar 17 2022, 11:01 AM
atul mentioned this in rCOMMa755424beee0: [web] Remove `div.content` from `Splash`.Mar 17 2022, 11:17 AM
atul mentioned this in rCOMMe34d88b6b0d0: [web] Remove everything from `Splash` except Log in button.Mar 17 2022, 11:21 AM

Revision Contents
Changeset List

PathSize
web/
splash/
110 lines
191 lines

Diff 10483

View Options

web/splash/splash.css

Loading...
View Options

web/splash/splash.react.js

Loading...