Paths

Table of Contentst

[web] Remove `div.bottomContainer` from `Splash`
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 3:09 PM.

Details

Reviewers

• jacek
tomek
• benschac
varun

Commits

rCOMM85f151280180: [web] Remove `div.bottomContainer` from `Splash`

Summary

Cut div.bottomContainer in splash.react.js and associated styles in splash.css.

Here's how it looks:

depends on D3447

Test Plan

Same as D3447 (tldr: make sure we can still log in, etc)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 16 2022, 3:09 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 16 2022, 3:09 PM

atul published this revision for review.Mar 16 2022, 3:10 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7434: Diff 10464.Mar 16 2022, 3:15 PM

Should all of these diffs relating to the splash page be in a linked stack on phabricator? Looks good otherwise.

• benschac accepted this revision.Mar 16 2022, 5:43 PM

This revision is now accepted and ready to land.Mar 16 2022, 5:43 PM

atul edited the summary of this revision. (Show Details)Mar 16 2022, 9:11 PM

atul added a parent revision: D3447: [web] Remove "Request Access" markup/styling from `Splash` component.

atul added a child revision: D3449: [web] Remove `div.content` from `Splash`.

In D3448#93619, @benschac wrote:

Should all of these diffs relating to the splash page be in a linked stack on phabricator? Looks good otherwise.

yeah thanks for catching, meant to do all the "depends on" stuff at the end.. but then forgot

atul added 1 blocking reviewer(s): tomek.Mar 16 2022, 9:47 PM

This revision now requires review to proceed.Mar 16 2022, 9:47 PM

atul changed 2 blocking reviewer(s), added 1: ashoat; removed 1: tomek.Mar 17 2022, 8:12 AM

tomek accepted this revision.Mar 17 2022, 10:40 AM

atul removed a reviewer: ashoat.Mar 17 2022, 10:59 AM

This revision is now accepted and ready to land.Mar 17 2022, 10:59 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 17 2022, 11:02 AM

Closed by commit rCOMM85f151280180: [web] Remove `div.bottomContainer` from `Splash` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM85f151280180: [web] Remove `div.bottomContainer` from `Splash`.

Harbormaster failed remote builds in B7446: Diff 10484!Mar 17 2022, 11:03 AM

Revision Contents
Changeset List

Path

Size

web/

splash/

splash.css

42 lines

splash.react.js

16 lines

Diff 10485

View Options

web/splash/splash.css