Page MenuHomePhabricator

[web] [fix] remove no message italic
AbandonedPublic

Authored by benschac on Mar 21 2022, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 9:27 AM
Unknown Object (File)
Sat, Nov 9, 5:53 PM
Unknown Object (File)
Sat, Nov 9, 8:48 AM
Unknown Object (File)
Sat, Nov 9, 7:12 AM
Unknown Object (File)
Fri, Nov 8, 12:46 PM
Unknown Object (File)
Wed, Nov 6, 1:15 PM
Unknown Object (File)
Oct 9 2024, 6:31 PM
Unknown Object (File)
Sep 12 2024, 3:08 PM

Details

Reviewers
atul
ashoat
Summary

we don't use italic anywhere in our design, so we can remove it.

Image 2022-03-21 at 3.48.38 PM.jpg (440×664 px, 25 KB)

Test Plan

go to a conversation with no message, it should not be italic

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Mar 21 2022, 10:19 PM

This makes it hard to distinguish between a one-on-one chat where the person said "No messages" to you, versus actually not having any messages. The designs simply do not handle this case, so the fact that you don't see italics doesn't seem super relevant

This revision now requires changes to proceed.Mar 21 2022, 10:19 PM

Italics aren't defined anywhere in the Figma files. I'm fine keeping them if you think it's helpful.