[services] Dev Mode - Apply local cloud to the Blob service
AbandonedPublic
Actions

Authored by • karol on Mar 23 2022, 7:58 AM.

Details

Reviewers

tomek
• max
varun
• jim

Summary

Depends on D3496

This replaces the old approach to the dev mode in the blob service with the local cloud.

Test Plan

cd services
yarn run-local-cloud
yarn setup-local-cloud
yarn test-blob-service-dev-mode

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 23 2022, 7:58 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 23 2022, 7:58 AM

Harbormaster completed remote builds in B7538: Diff 10607.Mar 23 2022, 8:08 AM

• karol requested review of this revision.Mar 23 2022, 8:08 AM

• karol edited the summary of this revision. (Show Details)Mar 23 2022, 8:11 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun, • jim.

• karol edited the summary of this revision. (Show Details)

• karol added a parent revision: D3496: [services] Dev Mode - setup local cloud.

• karol added a child revision: D3498: [services] Dev Mode - Apply local cloud to the Backup service.

This has conflicts with master as @jimpo refactored the folder structure in the blob service. You can still review this, I'm going to rebase later.

• karol planned changes to this revision.Mar 25 2022, 5:15 AM

rebase with master

Putting @jimpo as blocking to make sure we're thinking about Docker / Docker Compose correctly

Also, it looks like something went wrong with CI since it still hasn't finished processing. I think there is some way to restart it from the Buildkite website (@atul?), or you can just trigger a new build with another arc diff

• jim requested changes to this revision.Apr 4 2022, 1:35 PM

• jim added inline comments.

services/blob/src/AwsTools.cpp
31	This should be an configuration or environment variable check, not a compile-time flag. Same as https://phabricator.ashoat.com/D3498#inline-21489.

This revision now requires changes to proceed.Apr 4 2022, 1:35 PM

I changed my approach, now I used terraform for this. I'm abandoning this one. I decided that it will be faster to set up a new stack as I reordered the diffs and a lot of the differed from the ones from this stack. Let's follow up in the stack beginning at D3695.