[server] Add baseRoutePath to app URL config JSON
ClosedPublic
Actions

Authored by ashoat on Mar 29 2022, 3:22 PM.

Details

Reviewers

varun
atul
tomek

Commits

rCOMM453a8a435a27: [server] Add baseRoutePath to app URL config JSON

Summary

Just basePath (external) isn't enough – to properly detect what external URL triggered the request, we need to check if the internal URL starts with a particular baseRoutePath. We also need this in order to find/replace the internal URL so we can get the external URL.

Test Plan

This diff was tested in combination with the following diffs. On its own, it just changes a type

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 29 2022, 3:22 PM

Herald added subscribers: • abosh, • benschac, • karol, • adrian. · View Herald TranscriptMar 29 2022, 3:22 PM

ashoat added a child revision: D3548: [server] Introduce migration that adds baseRoutePath to AppURLFacts.Mar 29 2022, 3:23 PM

Harbormaster completed remote builds in B7693: Diff 10795.Mar 29 2022, 3:28 PM

ashoat requested review of this revision.Mar 29 2022, 3:28 PM

varun accepted this revision.Mar 29 2022, 3:31 PM

This revision is now accepted and ready to land.Mar 29 2022, 3:31 PM

Closed by commit rCOMM453a8a435a27: [server] Add baseRoutePath to app URL config JSON (authored by ashoat). · Explain WhyMar 30 2022, 11:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM453a8a435a27: [server] Add baseRoutePath to app URL config JSON.

Revision Contents
Changeset List

Path

Size

server/

src/

utils/

urls.js

5 lines

Diff 10831

View Options

server/src/utils/urls.js

	FROM commapp/services-base:1.3.2 as builder			FROM rust:1.70-bullseye as builder

	ENV PATH=/root/.cargo/bin:$PATH			RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
				build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
	# Install Curl
	RUN apt-get update \
	&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
	&& rm -rf /var/lib/apt/lists/*			&& rm -rf /var/lib/apt/lists/*

	# Install Rust			WORKDIR /home/root/app/feature-flags
	RUN curl https://sh.rustup.rs -sSf \| sh -s -- -y

	RUN mkdir -p /home/comm/app/feature-flags
	WORKDIR /home/comm/app/feature-flags
	RUN cargo init --bin

	# Cache build dependencies in a new layer			ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
	COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
	COPY services/comm-services-lib ../comm-services-lib
	RUN cargo build --release

	# Copy actual application sources			# Copy actual application sources
	COPY services/feature-flags .			COPY services/comm-services-lib ../comm-services-lib
				COPY services/feature-flags ./

	# Remove the previously-built binary so that only the application itself is			RUN cargo install --locked --path .
	# rebuilt
	RUN rm -f ./target/release/deps/feature-flags*
	RUN cargo build --release

	# Runner stage			# Runner stage
	FROM commapp/services-base:1.3.2 as runner			FROM debian:bullseye-slim as runner

	# Create a new user comm and use it to run subsequent commands			# Update dependencies, install ca-certificates which are required for TLS
	RUN useradd -m comm			RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
	USER comm			ca-certificates \
				&& rm -rf /var/lib/apt/lists/*

	# Only copy built binary from builder stage			# Only copy built binary from builder stage
				COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
	WORKDIR /home/comm/app/feature-flags			WORKDIR /home/comm/app/feature-flags
	COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .

	ARG COMM_SERVICES_SANDBOX			# Create a new user comm and use it to run subsequent commands
	ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}			RUN useradd -m comm
				USER comm

				ENV RUST_LOG=info

	CMD ./feature-flags			CMD ["feature-flags"]

[server] Add baseRoutePath to app URL config JSONClosedPublicActions