Page MenuHomePhabricator

[server] Add baseRoutePath to app URL config JSON
ClosedPublic

Authored by ashoat on Mar 29 2022, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 3:44 PM
Unknown Object (File)
Mon, Jun 24, 11:51 PM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
Unknown Object (File)
Fri, Jun 21, 11:40 PM
Unknown Object (File)
Fri, Jun 21, 1:02 PM
Unknown Object (File)
Wed, Jun 19, 5:11 PM

Details

Summary

Just basePath (external) isn't enough – to properly detect what external URL triggered the request, we need to check if the internal URL starts with a particular baseRoutePath. We also need this in order to find/replace the internal URL so we can get the external URL.

Test Plan

This diff was tested in combination with the following diffs. On its own, it just changes a type

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable