Page MenuHomePhabricator

[server] Use separate Express router for landing page
ClosedPublic

Authored by ashoat on Mar 29 2022, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 1:06 AM
Unknown Object (File)
Sun, Jun 23, 4:43 PM
Unknown Object (File)
Sat, Jun 22, 9:48 PM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
Unknown Object (File)
Fri, Jun 21, 11:40 PM
Unknown Object (File)
Wed, Jun 19, 12:50 PM

Details

Summary

This diff also makes us no longer needs server/facts/url.json. The baseRoutePath that was there was ostensibly a global one, but if we have distinct routers for each "app", we don't need a global baseRoutePath anymore.

Depends on D3550

Test Plan
  1. We tested the landing page, the SquadCal app, and the Comm app
  2. We made sure we tried configs where baseRoutePath !== basePath
  3. We also checked view-source to make sure things were set correctly
  4. We made sure there were no errors in the browser console
  5. We played around with the site, logging in and navigating and making sure things worked correctly
  6. We tried loading a specific URL for a specific chat directly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 3:35 PM
Harbormaster failed remote builds in B7697: Diff 10799!
varun added inline comments.
server/src/database/migrations.js
44–46 ↗(On Diff #10799)

unlink is wrapped in a try-catch so that the migration is idempotent

This revision is now accepted and ready to land.Mar 30 2022, 11:01 AM