Page MenuHomePhabricator
Differential D3563

Remove 'Need notif permissions' alert from iOS since apple revievers requested to do so
ClosedPublic
Actions

Authored by marcin on Mar 30 2022, 7:06 AM.
Tags
None
Referenced Files
F5071786: D3563.id12344.diff
Fri, Mar 28, 5:36 AM
Unknown Object (File)
Thu, Mar 20, 12:37 AM
Unknown Object (File)
Tue, Mar 4, 8:03 AM
Unknown Object (File)
Mon, Mar 3, 7:54 AM
Unknown Object (File)
Feb 10 2025, 10:12 PM
Unknown Object (File)
Jan 28 2025, 2:16 PM
Unknown Object (File)
Jan 27 2025, 9:11 PM
Unknown Object (File)
Jan 27 2025, 9:11 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac

Details

Reviewers
tomek
• jacek
ashoat
Commits
rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested…
Summary

This differential stops showing "Need notif permissions" alert on iOS but leaves it for android. This change was requested by apple reviewers.

Test Plan

Build app, disable notifications both at the beggining and later in settings and check that alert does not appear in iOS.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Mar 30 2022, 7:06 AM
Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptMar 30 2022, 7:06 AM
Harbormaster completed remote builds in B7714: Diff 10816.Mar 30 2022, 7:12 AM
marcin requested review of this revision.Mar 30 2022, 7:12 AM
marcin added a child revision: D3564: Set deviceToken to null upon notification permissions acquisition failure.Mar 30 2022, 7:24 AM
ashoat accepted this revision.Mar 30 2022, 10:41 PM
This revision is now accepted and ready to land.Mar 30 2022, 10:41 PM
marcin updated this revision to Diff 11001.Apr 4 2022, 7:23 AM

Rebase after introducing D3608

marcin added a parent revision: D3608: Android bugfix: call failedToRegisterPushPermission of PushHandler if notifications are disabled.Apr 4 2022, 7:25 AM
Harbormaster completed remote builds in B7833: Diff 11001.Apr 4 2022, 12:04 PM
marcin updated this revision to Diff 11340.Apr 12 2022, 4:14 AM

Rebase

Harbormaster completed remote builds in B8113: Diff 11340.Apr 12 2022, 4:21 AM
marcin updated this revision to Diff 11978.Apr 27 2022, 5:22 AM

Rebase

Harbormaster completed remote builds in B8594: Diff 11978.Apr 27 2022, 5:30 AM
marcin updated this revision to Diff 12202.May 4 2022, 5:09 AM

Rebase

Harbormaster completed remote builds in B8756: Diff 12202.May 4 2022, 6:29 AM
marcin updated this revision to Diff 12344.May 6 2022, 3:35 AM

Rebase

Harbormaster completed remote builds in B8849: Diff 12344.May 6 2022, 3:41 AM
• karol removed a subscriber: • karol.May 6 2022, 3:56 AM
marcin updated this revision to Diff 12418.May 9 2022, 5:24 AM

Rebase

Harbormaster completed remote builds in B8913: Diff 12418.May 9 2022, 5:30 AM
Closed by commit rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested… (authored by marcin). · Explain WhyMay 9 2022, 5:50 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested….

Revision Contents
Changeset List

PathSize
native/
push/
35 lines

Diff 12423

View Options

native/push/push-handler.react.js

Show First 20 Lines • Show All 383 Lines • ▼ Show 20 Linesclass PushHandler extends React.PureComponent<Props, State> {
failedToRegisterPushPermissions = () => { failedToRegisterPushPermissions = () => {
if (!this.props.loggedIn) { if (!this.props.loggedIn) {
return; return;
} }
const deviceType = Platform.OS; const deviceType = Platform.OS;
if (deviceType === 'ios') { if (deviceType === 'ios') {
iosPushPermissionResponseReceived(); iosPushPermissionResponseReceived();
if (__DEV__) { } else {
// iOS simulator can't handle notifs this.showNotifAlertOnAndroid();
return;
}
} }
};
showNotifAlertOnAndroid() {
const alertInfo = this.props.notifPermissionAlertInfo; const alertInfo = this.props.notifPermissionAlertInfo;
if ( if (
(alertInfo.totalAlerts > 3 && (alertInfo.totalAlerts > 3 &&
alertInfo.lastAlertTime > Date.now() - msInDay) || alertInfo.lastAlertTime > Date.now() - msInDay) ||
(alertInfo.totalAlerts > 6 && (alertInfo.totalAlerts > 6 &&
alertInfo.lastAlertTime > Date.now() - msInDay * 3) || alertInfo.lastAlertTime > Date.now() - msInDay * 3) ||
(alertInfo.totalAlerts > 9 && (alertInfo.totalAlerts > 9 &&
alertInfo.lastAlertTime > Date.now() - msInDay * 7) alertInfo.lastAlertTime > Date.now() - msInDay * 7)
) { ) {
return; return;
} }
this.props.dispatch({ this.props.dispatch({
type: recordNotifPermissionAlertActionType, type: recordNotifPermissionAlertActionType,
payload: { time: Date.now() }, payload: { time: Date.now() },
}); });
if (deviceType === 'ios') {
Alert.alert(
'Need notif permissions',
'Comm needs notification permissions to keep you in the loop! ' +
'Please enable in Settings App -> Notifications -> Comm.',
[{ text: 'OK' }],
);
} else if (deviceType === 'android') {
Alert.alert( Alert.alert(
'Unable to initialize notifs!', 'Unable to initialize notifs!',
'Please check your network connection, make sure Google Play ' + 'Please check your network connection, make sure Google Play ' +
'services are installed and enabled, and confirm that your Google ' + 'services are installed and enabled, and confirm that your Google ' +
'Play credentials are valid in the Google Play Store.', 'Play credentials are valid in the Google Play Store.',
undefined, undefined,
{ cancelable: true }, { cancelable: true },
); );
} }
};
navigateToThread(threadInfo: ThreadInfo, clearChatRoutes: boolean) { navigateToThread(threadInfo: ThreadInfo, clearChatRoutes: boolean) {
if (clearChatRoutes) { if (clearChatRoutes) {
this.props.navigation.dispatch({ this.props.navigation.dispatch({
type: replaceWithThreadActionType, type: replaceWithThreadActionType,
payload: { threadInfo }, payload: { threadInfo },
}); });
} else { } else {
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines