Paths

Table of Contentst

Differential D3599

[web] Introduce `Subchannel` component
ClosedPublic
Actions

Authored by • jacek on Apr 1 2022, 7:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 8:01 AM

	Unknown Object (File)
	Nov 16 2024, 9:59 PM

	Unknown Object (File)
	Nov 16 2024, 8:28 PM

	Unknown Object (File)
	Nov 16 2024, 7:42 PM

	Unknown Object (File)
	Nov 16 2024, 6:01 PM

	Unknown Object (File)
	Nov 14 2024, 4:34 PM

	Unknown Object (File)
	Nov 13 2024, 12:45 PM

	Unknown Object (File)
	Nov 13 2024, 12:45 PM

Subscribers

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM89dff72c45f7: [web] Introduce `Subchannel` component

Summary

Introduce component for displaying single subchannel with preview in thread subchannels modal

Screenshot_Google Chrome_2022-04-01_164016@2x.png (906×696 px, 89 KB)

Figma:

Screenshot_Figma_2022-04-01_164109.png (645×451 px, 35 KB)

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=633%3A58861

Test Plan

The component is not used yet. The component can be tested when introducing subchannels modal.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 1 2022, 7:29 AM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptApr 1 2022, 7:29 AM

• jacek edited the summary of this revision. (Show Details)Apr 1 2022, 7:41 AM

• jacek added reviewers: • benschac, atul.

Harbormaster completed remote builds in B7798: Diff 10959.Apr 1 2022, 7:46 AM

• jacek requested review of this revision.Apr 1 2022, 7:46 AM

• jacek added a child revision: D3600: [web] Introduce `SubchannelsModal`.Apr 1 2022, 7:48 AM

• jacek added a parent revision: D3598: [lib] Introduce `useFilteredChatListData` hook.

• jacek edited parent revisions, added: D3597: [web] [lib] Introduce `getMessagePreview` function; removed: D3598: [lib] Introduce `useFilteredChatListData` hook.

tomek requested changes to this revision.Apr 4 2022, 2:28 AM

tomek added inline comments.

web/modals/threads/subchannels/subchannel.react.js
17 ↗	(On Diff #10959)	Readonly
50–62 ↗	(On Diff #10959)	As a good practice, we can make this more efficient: we're not interested in whole `mostRecentMessageInfo`. We only care if it is defined, so we can introduce a new variable that contains this info and depend on it. (After changes from D3597 its probably no longer relevant)
web/modals/threads/subchannels/subchannels-modal.css
15–16 ↗	(On Diff #10959)	Why do we set `row-gap` when displaying elements in column?

This revision now requires changes to proceed.Apr 4 2022, 2:28 AM

• jacek added inline comments.Apr 4 2022, 4:37 AM

web/modals/threads/subchannels/subchannels-modal.css
15–16 ↗	(On Diff #10959)	When we display elements in column, we have multiple rows containing items, so to define space between these rows we set `row-gap`, don't we?

tomek added inline comments.Apr 4 2022, 4:46 AM

web/modals/threads/subchannels/subchannels-modal.css
15–16 ↗	(On Diff #10959)	Ah, sorry, you're right!

rebase & fix css & fix ReadOnly

Harbormaster failed remote builds in B7826: Diff 10993!Apr 4 2022, 6:35 AM

tomek accepted this revision.Apr 5 2022, 7:07 AM

This revision is now accepted and ready to land.Apr 5 2022, 7:07 AM

rebase

Harbormaster completed remote builds in B8009: Diff 11214.Apr 8 2022, 2:34 AM

Closed by commit rCOMM89dff72c45f7: [web] Introduce `Subchannel` component (authored by • jacek). · Explain WhyApr 8 2022, 7:10 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM89dff72c45f7: [web] Introduce `Subchannel` component.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

subchannels/

subchannel.react.js

75 lines

subchannels-modal.css

39 lines

2 lines

Diff 11237

web/modals/threads/subchannels/subchannel.react.js

Loading...

web/modals/threads/subchannels/subchannels-modal.css

Loading...

web/theme.css

Loading...