[web] Introduce `SubchannelsModal`
ClosedPublic
Actions

Authored by • jacek on Apr 1 2022, 7:31 AM.

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM2a88a2f330a7: [web] Introduce `SubchannelsModal`

Summary

Introduce modal with subchannels list.
Currently, it doesn't display message previews from threads that user is not member of - the next diff will introduce fetching proper data from server

Screenshot_Google Chrome_2022-04-01_164240@2x.png (978×800 px, 89 KB)

FIgma:

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=633%3A58861

Test Plan

Component will be accessible from thread menu after the diff introducing "Subchannels" action into thread menu.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 1 2022, 7:31 AM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptApr 1 2022, 7:31 AM

• jacek edited the summary of this revision. (Show Details)Apr 1 2022, 7:43 AM

• jacek edited the test plan for this revision. (Show Details)

• jacek added reviewers: • benschac, atul.

• jacek added a child revision: D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.Apr 1 2022, 7:47 AM

• jacek added a parent revision: D3599: [web] Introduce `Subchannel` component.

• jacek added a parent revision: D3598: [lib] Introduce `useFilteredChatListData` hook.

Harbormaster completed remote builds in B7799: Diff 10960.Apr 1 2022, 7:53 AM

• jacek requested review of this revision.Apr 1 2022, 7:53 AM

ashoat added inline comments.Apr 1 2022, 12:20 PM

web/modals/threads/subchannels/subchannels-modal.react.js
47 ↗	(On Diff #10960)	I think it would be good to pull this out into its own `React.useMemo`, so we don't have to redo the search if only `allSubchannelsChatList` changes

After D3494 is landed you could use SearchModal here

web/modals/threads/subchannels/subchannels-modal.css
4–5 ↗	(On Diff #10960)	Why do we need row gap when displaying a column?
web/modals/threads/subchannels/subchannels-modal.react.js
36 ↗	(On Diff #10960)	`subchannelsIDs` should be a `Set` so that we could filter here effectively

This revision now requires changes to proceed.Apr 4 2022, 3:02 AM

use SearchModal & improvements after review

• jacek added a parent revision: D3494: [web] Introduce search modal component.Apr 4 2022, 6:36 AM

Harbormaster failed remote builds in B7828: Diff 10996!Apr 4 2022, 6:40 AM

tomek accepted this revision.Apr 5 2022, 7:15 AM

tomek added inline comments.

web/modals/threads/subchannels/subchannels-modal.react.js
23 ↗	(On Diff #10996)	We usually use only a single plural form e.g. `subchannelIDs`

This revision is now accepted and ready to land.Apr 5 2022, 7:15 AM

There are some eslint issues reported by CI

I wonder why the ESLint issues weren't caught during git commit via lint-staged

There are some eslint issues reported by CI

It looks like the logs say Exited with status -1 (agent lost) which indicates a network issue. Restarted the Flow/ESLint/Jest job and there don't appear to be ESLint issues?