Page MenuHomePhabricator
Differential D3642

[services] Tunnelbroker - Fix `GetN()`->`GetS()`.
ClosedPublic
Actions

Authored by • max on Apr 7 2022, 2:58 AM.
Tags
None
Referenced Files
F2904926: D3642.diff
Sun, Oct 6, 2:48 AM
Unknown Object (File)
Mon, Sep 23, 3:57 AM
Unknown Object (File)
Mon, Sep 23, 3:57 AM
Unknown Object (File)
Mon, Sep 23, 3:57 AM
Unknown Object (File)
Mon, Sep 23, 3:56 AM
Unknown Object (File)
Thu, Sep 19, 2:27 AM
Unknown Object (File)
Wed, Sep 18, 3:44 AM
Unknown Object (File)
Tue, Sep 17, 12:04 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
varun
Commits
rCOMM46e5cc697cdb: [services] Tunnelbroker - Fix `GetN()`->`GetS()`.
Summary

This is a small fix error on std:stoull that throws an exception because it's expecting a string, but we return the number in GetN().
We've agreed before that we should use GetS() from AWS C++ SDK everywhere.
This diff changes GetN()->GetS().

Test Plan

Run yarn test-tunnelbroker-service and successfully build the app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Apr 7 2022, 2:58 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 7 2022, 2:58 AM
• max added reviewers: • karol, tomek, varun.Apr 7 2022, 2:58 AM
Harbormaster completed remote builds in B7956: Diff 11160.Apr 7 2022, 3:05 AM
• max requested review of this revision.Apr 7 2022, 3:05 AM
• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.Apr 7 2022, 3:22 AM
• max removed a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.
• max added a child revision: D3643: [services] Tunnelbroker - Database item tests initialization.
• karol accepted this revision.Apr 7 2022, 3:45 AM
tomek accepted this revision.Apr 8 2022, 12:30 AM
This revision is now accepted and ready to land.Apr 8 2022, 12:30 AM
• max updated this revision to Diff 11268.Apr 11 2022, 2:11 AM

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 11 2022, 2:13 AM
Closed by commit rCOMM46e5cc697cdb: [services] Tunnelbroker - Fix `GetN()`->`GetS()`. (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM46e5cc697cdb: [services] Tunnelbroker - Fix `GetN()`->`GetS()`..
Harbormaster completed remote builds in B8051: Diff 11268.Apr 11 2022, 2:16 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Database/
2 lines

Diff 11269

View Options

services/tunnelbroker/src/Database/MessageItem.cpp

Loading...