Details
Render a couple of rows for users with different relationship statuses (friend, request sent, request received) and check if correct buttons are rendered.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/settings/relationship/friend-list-row.react.js | ||
|---|---|---|
| 15 ↗ | (On Diff #11244) | I feel like this logic should more closely follow: https://github.com/CommE2E/comm/blob/master/web/chat/relationship-prompt/relationship-prompt.js maybe we could move it to lib and use the logic in both places? |
| 17 ↗ | (On Diff #11244) | nit: can we use <button> |
| web/settings/relationship/friend-list-row.react.js | ||
|---|---|---|
| 15 ↗ | (On Diff #11244) | Thanks for suggestion, but at this point I don't see any logic that can be shared. We have different labels in each of these places and in this diff we're not calling the api - so it also can't be shared. But I do agree, that once friend-list calls the api, there might be some place for reusability. Will give it a try while introducing it. |
| 17 ↗ | (On Diff #11244) | Ok, makes sense |
| web/settings/relationship/friend-list-row.react.js | ||
|---|---|---|
| 15 ↗ | (On Diff #11244) | After analyzing the differences it doesn't seem like we can share any logic here. E.g. when users are friends, we don't want to display any action in the prompt, but in the setting we show edit icon. |