[lib] Delete extraneous invariant and dependency from relationship change callback
ClosedPublic
Actions

Authored by tomek on Apr 14 2022, 11:41 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM5ca80568eb18: [lib] Delete extraneous invariant and dependency from relationship change…

Summary

This invariant isn't necessary, because the value isn't used in the callback. Also, the dependency on userID is still present, but indirectly through updateRelationship function.
Depends on D3732

Test Plan

Send friend request by using relationship prompt and check if the state was updated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 14 2022, 11:41 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 14 2022, 11:41 AM

tomek added a child revision: D3734: [lib] Introduce relationship callbacks.Apr 14 2022, 11:42 AM

Harbormaster completed remote builds in B8211: Diff 11482.Apr 14 2022, 11:52 AM

tomek requested review of this revision.Apr 14 2022, 11:52 AM

Nice

This revision is now accepted and ready to land.Apr 14 2022, 5:33 PM

Closed by commit rCOMM5ca80568eb18: [lib] Delete extraneous invariant and dependency from relationship change… (authored by tomek). · Explain WhyApr 15 2022, 2:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5ca80568eb18: [lib] Delete extraneous invariant and dependency from relationship change….

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-prompt.js

6 lines

Diff 11505

View Options

lib/hooks/relationship-prompt.js

[lib] Delete extraneous invariant and dependency from relationship change callbackClosedPublicActions