[lib] Fix memoization of useRelationshipPrompt
ClosedPublic
Actions

Authored by tomek on Apr 14 2022, 11:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 4:24 AM

	Unknown Object (File)
	Wed, Oct 16, 8:39 AM

	Unknown Object (File)
	Wed, Oct 16, 8:39 AM

	Unknown Object (File)
	Wed, Oct 9, 8:10 PM

	Unknown Object (File)
	Wed, Oct 9, 8:10 PM

	Unknown Object (File)
	Wed, Oct 9, 8:09 PM

	Unknown Object (File)
	Wed, Oct 9, 7:50 PM

	Unknown Object (File)
	Oct 6 2024, 9:24 AM

Subscribers

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt

Summary

We were using callbacks but the return value was never memoized.
Depends on D3734

Test Plan

Send friend request by using relationship prompt and check if the state was updated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 14 2022, 11:43 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 14 2022, 11:43 AM

tomek added a child revision: D3736: [web] Use relationship callback on friend list.Apr 14 2022, 11:44 AM

Harbormaster completed remote builds in B8213: Diff 11484.Apr 14 2022, 11:52 AM

tomek requested review of this revision.Apr 14 2022, 11:52 AM

atul accepted this revision.Apr 14 2022, 7:30 PM

This revision is now accepted and ready to land.Apr 14 2022, 7:30 PM

Closed by commit rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt (authored by tomek). · Explain WhyApr 15 2022, 2:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-prompt.js

11 lines

Diff 11507

View Options

lib/hooks/relationship-prompt.js

[lib] Fix memoization of useRelationshipPromptClosedPublicActions