Differential D3735

[lib] Fix memoization of useRelationshipPrompt
ClosedPublic
Actions

Authored by tomek on Apr 14 2022, 11:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 28, 7:06 AM

	Unknown Object (File)
	Fri, Mar 28, 7:06 AM

	Unknown Object (File)
	Tue, Mar 25, 2:40 AM

	Unknown Object (File)
	Tue, Mar 25, 2:40 AM

	Unknown Object (File)
	Wed, Mar 19, 1:58 AM

	Unknown Object (File)
	Sat, Mar 15, 3:25 AM

	Unknown Object (File)
	Wed, Mar 12, 4:26 AM

	Unknown Object (File)
	Mon, Mar 10, 10:08 AM

Subscribers

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt

Summary

We were using callbacks but the return value was never memoized.
Depends on D3734

Test Plan

Send friend request by using relationship prompt and check if the state was updated.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 14 2022, 11:43 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 14 2022, 11:43 AM

tomek added a child revision: D3736: [web] Use relationship callback on friend list.Apr 14 2022, 11:44 AM

Harbormaster completed remote builds in B8213: Diff 11484.Apr 14 2022, 11:52 AM

tomek requested review of this revision.Apr 14 2022, 11:52 AM

atul accepted this revision.Apr 14 2022, 7:30 PM

This revision is now accepted and ready to land.Apr 14 2022, 7:30 PM

Closed by commit rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt (authored by tomek). · Explain WhyApr 15 2022, 2:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9b4481c37d33: [lib] Fix memoization of useRelationshipPrompt.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-prompt.js

11 lines

Diff 11507

lib/hooks/relationship-prompt.js

This file was added.

				// 400KiB limit (in docs there is KB but they mean KiB) -
				// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
				// This includes both attribute names' and values' lengths
				pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;

				// 4MB limit
				// WARNING: use keeping in mind that grpc adds its own headers to messages
				// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
				// so the message that actually is being sent over the network looks like this
				// [Compressed-Flag] [Message-Length] [Message]
				// [Compressed-Flag] 1 byte - added by grpc
				// [Message-Length] 4 bytes - added by grpc
				// [Message] N bytes - actual data
				// so for every message we get 5 additional bytes of data
				// as mentioned here
				// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
				// grpc stream may contain more than one message
				pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
				pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;