Page MenuHomePhabricator
Differential D3687

[services] Tunnelbroker - Database SessionSignatureItem tests
ClosedPublic
Actions

Authored by • max on Apr 11 2022, 3:40 AM.
Tags
None
Referenced Files
F3380010: D3687.diff
Wed, Nov 27, 8:31 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:06 PM
Unknown Object (File)
Sun, Nov 3, 3:59 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
varun
Commits
rCOMMf456a1f750ec: [services] Tunnelbroker - Database SessionSignatureItem tests
Summary

Database (DynamoDB) item tests. For the SessionSignatureItem database entity we perform:

  • Check if the table is available,
  • Create and fulfill database item entity,
  • Put into the database table,
  • Find the record using the primary key,
  • Compare record fields of created item and item from database record,
  • Remove the testing record from the database.

Related linear task: ENG-686

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository
rCOMM Comm
Branch
tunnelbroker-tests-database-sessionsignitem
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Apr 11 2022, 3:40 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 11 2022, 3:40 AM
• max added reviewers: • karol, tomek, varun.Apr 11 2022, 3:41 AM
• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.
Harbormaster completed remote builds in B8055: Diff 11274.Apr 11 2022, 3:45 AM
• max requested review of this revision.Apr 11 2022, 3:45 AM
• max mentioned this in D3643: [services] Tunnelbroker - Database item tests initialization.Apr 11 2022, 3:55 AM
tomek requested changes to this revision.Apr 11 2022, 5:14 AM

We also need to clarify our approach to randomness in D3654

services/tunnelbroker/test/DatabaseManagerTest.cpp
39–44 ↗(On Diff #11274)

Like in D3686, let's compare strings

This revision now requires changes to proceed.Apr 11 2022, 5:14 AM
• max updated this revision to Diff 11292.Apr 11 2022, 6:41 AM

Switch from memcmp to a simple EQ.

• max planned changes to this revision.Apr 11 2022, 6:41 AM
• max marked an inline comment as done.

Switching to the Plan changes until we clarify the random/non-random value for tests.

Harbormaster completed remote builds in B8073: Diff 11292.Apr 11 2022, 6:57 AM
• max updated this revision to Diff 11548.Apr 18 2022, 7:08 AM

Added tests with static variables along with generated ones following D3654#102087.

Harbormaster completed remote builds in B8257: Diff 11548.Apr 18 2022, 7:13 AM
• max added 1 blocking reviewer(s): tomek.Apr 19 2022, 2:07 AM
tomek accepted this revision.Apr 19 2022, 2:30 AM

Not sure if it is possible, but maybe we can reduce duplication here by creating a function that receives SessionSignItem and does the testing. Then, in these two tests we would just create the item and call that function.

This revision is now accepted and ready to land.Apr 19 2022, 2:30 AM
• max updated this revision to Diff 11843.Apr 25 2022, 4:41 AM

Rebased on master.

Harbormaster completed remote builds in B8496: Diff 11843.Apr 25 2022, 4:46 AM
Closed by commit rCOMMf456a1f750ec: [services] Tunnelbroker - Database SessionSignatureItem tests (authored by • max). · Explain WhyApr 25 2022, 4:54 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMf456a1f750ec: [services] Tunnelbroker - Database SessionSignatureItem tests.
• max added a comment.Apr 25 2022, 4:57 AM
In D3687#104093, @palys-swm wrote:

Not sure if it is possible, but maybe we can reduce duplication here by creating a function that receives SessionSignItem and does the testing. Then, in these two tests we would just create the item and call that function.

I think it's possible, but not sure we need to spend time on this test now, as it doing its job now. But thanks for the suggestion!

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
test/
18 lines

Diff 11292

View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...