Page MenuHomePhabricator
Differential D3737

[web] [feat] [ENG-991] add promote api call to promote menu drop down
AbandonedPublic
Actions

Authored by • benschac on Apr 14 2022, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:42 AM
Unknown Object (File)
Tue, Nov 5, 6:03 AM
Unknown Object (File)
Sun, Nov 3, 5:16 PM
Unknown Object (File)
Oct 16 2024, 8:40 AM
Unknown Object (File)
Oct 16 2024, 8:40 AM
Unknown Object (File)
Oct 9 2024, 6:32 PM
Unknown Object (File)
Oct 9 2024, 6:20 PM
Unknown Object (File)
Oct 9 2024, 5:51 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• jacek
Summary

Add API call, makes promote menu button promote thread to chat list item, still need loading and error states. This is just making the API call, and the already implemented functionality for promoting thread in the shared redux store.

Screen Recording 2022-04-14 at 03.54.02 PM.gif (12 MB)

Test Plan

click the promote button on a thread that's promoteable. The logic for thread promotion showing correct sub-threads coming in the next diff.

Diff Detail

Repository
rCOMM Comm
Branch
benjamin/eng-991-promote-sidebar-to-subthread-on-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 14 2022, 12:49 PM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 14 2022, 12:49 PM
• benschac edited the test plan for this revision. (Show Details)Apr 14 2022, 12:53 PM
• benschac added reviewers: tomek, • jacek.
• benschac added a parent revision: D3731: [web] [feat] [ENG-991] add promote thread to menu dropdown.
• benschac edited the summary of this revision. (Show Details)Apr 14 2022, 12:56 PM
• benschac edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B8217: Diff 11488.Apr 14 2022, 12:56 PM
• benschac requested review of this revision.Apr 14 2022, 12:56 PM
• benschac edited the summary of this revision. (Show Details)Apr 14 2022, 1:00 PM
• jacek requested changes to this revision.Apr 15 2022, 2:40 AM
• jacek added inline comments.
web/chat/thread-menu.react.js
211–213

Do we need to wrap it in try... catch... block just to call console.error(e)? Isn't the exception shown in console anyway - without this block?
I don't think we have such a convention, as I searched through web code, and found that we use try... catch only in a few places where we're somehow handling an error by e.g. setting the state, and even then we throw an error again in catch.

This revision now requires changes to proceed.Apr 15 2022, 2:40 AM
• benschac added a child revision: D3746: [lib] [feat] [ENG-991] add usePromoteThread hook.Apr 15 2022, 8:19 AM
• benschac removed a child revision: D3746: [lib] [feat] [ENG-991] add usePromoteThread hook.Apr 15 2022, 10:24 AM
• benschac abandoned this revision.Apr 15 2022, 1:27 PM

this diff isn't relevant anymore after I refactored the onClickPromoteThread call into a hook in D3746

web/chat/thread-menu.react.js
211–213

I just copy pasted what was here: https://github.com/CommE2E/comm/blob/master/native/chat/settings/thread-settings-promote-sidebar.react.js#L80

but, I changed throw to console.error. Yeah, I agree with you, having the console.error doesn't do anything.

additionally, this diff isn't relevant anymore after I refacted the onClickPromoteThread call into a hook in D3746

Revision Contents
Changeset List

PathSize
web/
chat/
17 lines

Diff 11488

View Options

web/chat/thread-menu.react.js

Loading...