Add API call, makes promote menu button promote thread to chat list item, still need loading and error states. This is just making the API call, and the already implemented functionality for promoting thread in the shared redux store.
Details
Diff Detail
- Repository
- rCOMM Comm
- Branch
- benjamin/eng-991-promote-sidebar-to-subthread-on-web
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
web/chat/thread-menu.react.js | ||
---|---|---|
211–213 | Do we need to wrap it in try... catch... block just to call console.error(e)? Isn't the exception shown in console anyway - without this block? |
this diff isn't relevant anymore after I refactored the onClickPromoteThread call into a hook in D3746
web/chat/thread-menu.react.js | ||
---|---|---|
211–213 | I just copy pasted what was here: https://github.com/CommE2E/comm/blob/master/native/chat/settings/thread-settings-promote-sidebar.react.js#L80 but, I changed throw to console.error. Yeah, I agree with you, having the console.error doesn't do anything. additionally, this diff isn't relevant anymore after I refacted the onClickPromoteThread call into a hook in D3746 |