Paths

Table of Contentst

Differential D3748

[native] [refactor] [ENG-991] use usePromoteSidebar hook
ClosedPublic
Actions

Authored by • benschac on Apr 15 2022, 12:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:09 AM

	Unknown Object (File)
	Tue, Nov 5, 5:07 AM

	Unknown Object (File)
	Sun, Nov 3, 1:25 PM

Subscribers

Details

Reviewers

atul
• jacek
tomek

Commits

rCOMM862ab3ac242c: [native] [refactor] [ENG-991] use usePromoteSidebar hook

Summary

use hook in native, remove old code
https://linear.app/comm/issue/ENG-991/promote-sidebar-to-subthread-on-web

Test Plan

use promote thread feature like you normally would.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 15 2022, 12:43 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 12:43 PM

• benschac added a parent revision: D3746: [lib] [feat] [ENG-991] add usePromoteThread hook.Apr 15 2022, 12:44 PM

Harbormaster completed remote builds in B8238: Diff 11523.Apr 15 2022, 12:48 PM

• benschac requested review of this revision.Apr 15 2022, 12:48 PM

• benschac edited the summary of this revision. (Show Details)Apr 18 2022, 7:21 AM

• benschac added reviewers: • jacek, tomek.

• benschac added a child revision: D3755: [native] [feature] [ENG-1016] add alert prompt to user, promote thread cant be undone.Apr 18 2022, 8:17 AM

tomek requested changes to this revision.Apr 19 2022, 3:11 AM

tomek added inline comments.

native/chat/settings/thread-settings-promote-sidebar.react.js
7–8 ↗	(On Diff #11523)	These imports are inconsistent
73–78 ↗	(On Diff #11523)	We should use a callback for `onError`. In fact, we can even move this function outside the component - it doesn't depend on anything.

This revision now requires changes to proceed.Apr 19 2022, 3:11 AM

rebase

• benschac planned changes to this revision.Apr 19 2022, 8:15 AM

• benschac added inline comments.

native/chat/settings/thread-settings-promote-sidebar.react.js
73–78 ↗	(On Diff #11523)	ty! good catch!

rebase

Harbormaster completed remote builds in B8314: Diff 11611.Apr 19 2022, 11:08 AM

Harbormaster completed remote builds in B8320: Diff 11617.Apr 19 2022, 11:24 AM

tomek accepted this revision.Apr 20 2022, 9:43 AM

This revision is now accepted and ready to land.Apr 20 2022, 9:43 AM

• benschac mentioned this in D3746: [lib] [feat] [ENG-991] add usePromoteThread hook.Apr 20 2022, 10:19 AM

remove error arg

Harbormaster completed remote builds in B8354: Diff 11664.Apr 20 2022, 10:25 AM

Closed by commit rCOMM862ab3ac242c: [native] [refactor] [ENG-991] use usePromoteSidebar hook (authored by • benschac). · Explain WhyApr 21 2022, 6:13 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM862ab3ac242c: [native] [refactor] [ENG-991] use usePromoteSidebar hook.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings-promote-sidebar.react.js

75 lines

Diff 11726

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...