Page MenuHomePhabricator

[web] [feat] [ENG-991] add promote thread to menu dropdown
ClosedPublic

Authored by benschac on Apr 14 2022, 11:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:29 AM
Unknown Object (File)
Wed, Nov 20, 4:32 PM
Unknown Object (File)
Tue, Nov 12, 4:52 PM
Unknown Object (File)
Sun, Nov 10, 6:09 PM
Unknown Object (File)
Sun, Nov 10, 6:09 PM
Unknown Object (File)
Sun, Nov 10, 6:09 PM
Unknown Object (File)
Sun, Nov 10, 6:09 PM
Unknown Object (File)
Sun, Nov 10, 6:09 PM

Details

Summary

add promote option to the dropdown menu, with API hook.

  • The promote button shows in every dropdown. I need to add logic in another diff to only show it in sidebars that can be promoted.
  • Loading state needs to be added in another diff too.

https://linear.app/comm/issue/ENG-991/promote-sidebar-to-subthread-on-web

Test Plan

click menu, it should show, doesn't do anything yet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac edited the summary of this revision. (Show Details)

Isn't the screenshot in the diff description from some other task?

web/chat/thread-menu.react.js
205 ↗(On Diff #11480)

I'm not sure if it's a good name for this action now. I know that in some designs there is used the name "thread" for what is currently "sidebar" but I think we still use "sidebars" in other places. Maybe the action should be "Promote sidebar", or - as in mobile app - "Promote to full thread" for now?

This revision now requires changes to proceed.Apr 15 2022, 3:03 AM
web/chat/thread-menu.react.js
205 ↗(On Diff #11480)

I think for end-user (something the user will see on the UI) display it's right.

You're right, everything in the codebase is promoted sidebar, which should be the name in the code.

I chatted with @ashoat about this IRL. Just want to confirm we're on the same page.

In the code it probably makes sense to continue calling them sidebars, and using "thread" to refer to any generic chat. But in the copy (user-facing language) we should use "thread" for sidebar, "chat" for any generic chat, and "channel" for chats that aren't threads.

Still need to add logic of showing promote option on sidebar conversations in another diff.

Do you mean that at this point, we're always showing this button and your intention is to add logic, which limits this to only sidebar conversations, in another diff?

web/chat/thread-menu.react.js
200–209 ↗(On Diff #11522)

We can simplify a notation a bit by avoiding an explicit return

This revision is now accepted and ready to land.Apr 19 2022, 5:02 AM