Details

Reviewers

atul
• abosh
• jacek
tomek

Commits

rCOMMc940b617a254: [web] [feat] [ENG-991] add promote thread to menu dropdown

Summary

add promote option to the dropdown menu, with API hook.

The promote button shows in every dropdown. I need to add logic in another diff to only show it in sidebars that can be promoted.
Loading state needs to be added in another diff too.

https://linear.app/comm/issue/ENG-991/promote-sidebar-to-subthread-on-web

Test Plan

click menu, it should show, doesn't do anything yet

Diff Detail

Repository

rCOMM Comm

Branch

benjamin/eng-991-promote-sidebar-to-subthread-on-web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 14 2022, 11:34 AM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 14 2022, 11:34 AM

• benschac edited the summary of this revision. (Show Details)Apr 14 2022, 11:35 AM

• benschac added reviewers: • abosh, • jacek, tomek.

• benschac edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8209: Diff 11480.Apr 14 2022, 11:39 AM

• benschac requested review of this revision.Apr 14 2022, 11:39 AM

• benschac added a child revision: D3737: [web] [feat] [ENG-991] add promote api call to promote menu drop down.Apr 14 2022, 12:53 PM

Isn't the screenshot in the diff description from some other task?

web/chat/thread-menu.react.js
205	I'm not sure if it's a good name for this action now. I know that in some designs there is used the name "thread" for what is currently "sidebar" but I think we still use "sidebars" in other places. Maybe the action should be "Promote sidebar", or - as in mobile app - "Promote to full thread" for now?

This revision now requires changes to proceed.Apr 15 2022, 3:03 AM

• benschac added a parent revision: D3746: [lib] [feat] [ENG-991] add usePromoteThread hook.Apr 15 2022, 10:25 AM

• benschac edited the summary of this revision. (Show Details)

cleanup

Harbormaster completed remote builds in B8237: Diff 11522.Apr 15 2022, 12:38 PM

• benschac added inline comments.Apr 15 2022, 12:41 PM

web/chat/thread-menu.react.js
205	I think for end-user (something the user will see on the UI) display it's right. You're right, everything in the codebase is promoted sidebar, which should be the name in the code. I chatted with @ashoat about this IRL. Just want to confirm we're on the same page.

• benschac edited the summary of this revision. (Show Details)Apr 15 2022, 12:46 PM

In the code it probably makes sense to continue calling them sidebars, and using "thread" to refer to any generic chat. But in the copy (user-facing language) we should use "thread" for sidebar, "chat" for any generic chat, and "channel" for chats that aren't threads.

Still need to add logic of showing promote option on sidebar conversations in another diff.

Do you mean that at this point, we're always showing this button and your intention is to add logic, which limits this to only sidebar conversations, in another diff?