Run nix develop
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I don't believe I have the permissions to do so, there's nothing containing "Abandon" on my page.
Comment Actions
You should be able to find it in the "Add Action..." dropdown at the bottom of the page:
This comment was removed by varun.
Comment Actions
@jonringer-comm i think you meant to make this fix in https://phabricator.ashoat.com/D3274 . this diff needs to be re-abandoned now i think
Comment Actions
To your queue again. The fact that this diff got updated is concerning... it suggests something is messed up in @jonringer-comm local Git. Mastering the Phabricator / Arcanist workflow is crucial to being able to contribute on the team... might be good to do a call with @varun to figure out what's wrong in your local environment and to make sure this doesn't happen again
Comment Actions
You're still updating a diff that should've been abandoned!! Please review my previous comment
Comment Actions
I don’t think that’s right. I think you have something going wrong in your Git working copy. You likely have this revision in the commit message of the most recent commit when you run arc diff. You should sync with somebody on the team to get this resolved, and to build a better intuition for why this was happening in the first place and how to avoid it in the future.