Move changeThreadSettingsAction out from inner class component to outer "Connected" functional component.
As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)
Depends on D3794
Details
Details
- Open ThreadSettingsModal
- Mess with the settings
- Hit save and make sure things continue to look/work as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 471–472 ↗ | (On Diff #11681) | |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 475 ↗ | (On Diff #11681) | Only threadInfo.id is used in this callback (except in the invariant). Can we change the deps array to reflect that? |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 475 ↗ | (On Diff #11681) | Ran into the same issue as here: https://phabricator.ashoat.com/D3783?id=11652#inline-23122 |