Paths

Table of Contentst

-
web/modals/threads/
-
modals/
-
threads/
-
thread-settings-modal.react.js

Differential D3796

[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 3:21 PM.

Tags

None

Referenced Files

	F5875196: D3796.id11682.diff
	Thu, Apr 17, 12:30 AM

	Unknown Object (File)
	Wed, Apr 16, 3:34 PM

	Unknown Object (File)
	Wed, Apr 16, 3:04 PM

	Unknown Object (File)
	Wed, Apr 16, 2:06 AM

	Unknown Object (File)
	Tue, Apr 15, 9:06 PM

	Unknown Object (File)
	Tue, Apr 15, 2:10 AM

	Unknown Object (File)
	Sun, Apr 13, 7:30 AM

	Unknown Object (File)
	Tue, Apr 8, 7:04 PM

Subscribers

Details

Reviewers

tomek
• jacek

Commits

rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to…

Summary

Move onSubmit out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)

Depends on D3795

Test Plan

Open ThreadSettingsModal
Mess with the settings
Hit save and make sure things continue to look/work as expected

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 20 2022, 3:21 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 20 2022, 3:21 PM

Harbormaster completed remote builds in B8370: Diff 11682.Apr 20 2022, 3:26 PM

atul requested review of this revision.Apr 20 2022, 3:26 PM

atul added a child revision: D3797: [web] Move up `ComponentDid[Mount/Update]` functionality to `ConnectedThreadSettingsModal` `useEffect`.Apr 20 2022, 3:58 PM

tomek accepted this revision.Apr 21 2022, 8:50 AM

This revision is now accepted and ready to land.Apr 21 2022, 8:50 AM

rebase before landing

Harbormaster completed remote builds in B8475: Diff 11818.Apr 22 2022, 2:38 PM

Closed by commit rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 22 2022, 2:40 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.react.js

23 lines

Diff 11820

web/modals/threads/thread-settings-modal.react.js

	FROM commapp/services-base:1.1			FROM commapp/services-base:1.1

	RUN apt-get update && \			RUN apt-get update && \
	apt-get install -y uuid-dev && \			apt-get install -y uuid-dev && \
	rm -rf /var/lib/apt/lists/*			rm -rf /var/lib/apt/lists/*

	ARG COMM_TEST_SERVICES			ARG COMM_TEST_SERVICES
	ARG COMM_SERVICES_DEV_MODE			ARG COMM_SERVICES_DEV_MODE

	ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}			ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
	ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}			ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}

	WORKDIR /transferred			WORKDIR /transferred

	COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/			COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/
	COPY services/backup/docker/ scripts/
	COPY services/lib/ .			COPY services/lib/ .
	COPY services/backup/ .			COPY services/backup/ .

	RUN scripts/build_server.sh			RUN scripts/build_server.sh

	CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi			CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi