Page MenuHomePhabricator
Differential D3796

[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 3:21 PM.
Tags
None
Referenced Files
F3174385: D3796.diff
Thu, Nov 7, 4:28 PM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 2:05 AM
Unknown Object (File)
Mon, Oct 21, 11:37 PM
Unknown Object (File)
Sep 23 2024, 4:07 PM
Unknown Object (File)
Sep 23 2024, 4:06 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
Commits
rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to…
Summary

Move onSubmit out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)

Depends on D3795

Test Plan
  1. Open ThreadSettingsModal
  2. Mess with the settings
  3. Hit save and make sure things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
23 lines

Diff 11820

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...