Page MenuHomePhabricator
Differential D3766

[web] Move `onChangeDescription` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 18 2022, 2:40 PM.
Tags
None
Referenced Files
F5097989: D3766.id11647.diff
Mon, Mar 31, 12:28 AM
F5097853: D3766.diff
Mon, Mar 31, 12:11 AM
F5096740: D3766.id11575.diff
Sun, Mar 30, 9:26 PM
F5094274: D3766.id.diff
Sun, Mar 30, 2:44 PM
Unknown Object (File)
Sat, Mar 29, 3:53 PM
Unknown Object (File)
Mon, Mar 17, 6:41 PM
Unknown Object (File)
Wed, Mar 12, 10:19 PM
Unknown Object (File)
Wed, Mar 12, 4:32 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMMe92ffcc1d701: [web] Move `onChangeDescription` up from `ThreadSettingsModal` to…
Summary

Move onChangeDescription out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.

Depends on D3765

Test Plan
  1. Open ThreadSettingsModal
  2. Change the thread description a bunch
  3. Log values in onChangeDescription to ensure that they continue to be as expected
  4. Hit save after changing the description and ensure that the thread description changed as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2022, 2:40 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 2:40 PM
Harbormaster completed remote builds in B8279: Diff 11575.Apr 18 2022, 2:46 PM
atul requested review of this revision.Apr 18 2022, 2:46 PM
atul added a child revision: D3767: [web] Move `onChangeColor` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 18 2022, 2:51 PM
atul updated this revision to Diff 11647.Apr 19 2022, 3:03 PM

rebase

Harbormaster completed remote builds in B8337: Diff 11647.Apr 19 2022, 3:16 PM
tomek accepted this revision.Apr 21 2022, 3:06 AM

Accepting, as this is a simple change

web/modals/threads/thread-settings-modal.react.js
443–454 ↗(On Diff #11647)
This revision is now accepted and ready to land.Apr 21 2022, 3:06 AM
atul updated this revision to Diff 11742.Apr 21 2022, 10:45 AM

rebase before addressing feedback

atul updated this revision to Diff 11743.Apr 21 2022, 10:46 AM

addressed feedback: remove invariant use optional chaining

Harbormaster completed remote builds in B8416: Diff 11742.Apr 21 2022, 10:50 AM
Harbormaster completed remote builds in B8417: Diff 11743.Apr 21 2022, 10:53 AM
Closed by commit rCOMMe92ffcc1d701: [web] Move `onChangeDescription` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 21 2022, 10:55 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe92ffcc1d701: [web] Move `onChangeDescription` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
30 lines

Diff 11744

View Options

web/modals/threads/thread-settings-modal.react.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines