Page MenuHomePhabricator

[web] Move `onChangeDescription` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic

Authored by atul on Apr 18 2022, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 5:19 AM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sun, Nov 3, 6:04 PM
Unknown Object (File)
Sat, Nov 2, 12:18 PM

Details

Summary

Move onChangeDescription out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.


Depends on D3765

Test Plan
  1. Open ThreadSettingsModal
  2. Change the thread description a bunch
  3. Log values in onChangeDescription to ensure that they continue to be as expected
  4. Hit save after changing the description and ensure that the thread description changed as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 18 2022, 2:46 PM

Accepting, as this is a simple change

web/modals/threads/thread-settings-modal.react.js
443–454 ↗(On Diff #11647)
This revision is now accepted and ready to land.Apr 21 2022, 3:06 AM

rebase before addressing feedback

addressed feedback: remove invariant use optional chaining