Page MenuHomePhabricator
Differential D3796

[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 3:21 PM.
Tags
None
Referenced Files
F3348199: D3796.id11820.diff
Fri, Nov 22, 2:01 PM
F3348198: D3796.id11818.diff
Fri, Nov 22, 2:01 PM
F3348197: D3796.id11682.diff
Fri, Nov 22, 2:01 PM
F3348186: D3796.id.diff
Fri, Nov 22, 2:01 PM
F3348168: D3796.diff
Fri, Nov 22, 1:59 PM
Unknown Object (File)
Thu, Nov 14, 9:03 AM
Unknown Object (File)
Thu, Nov 14, 9:02 AM
Unknown Object (File)
Thu, Nov 14, 9:02 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
Commits
rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to…
Summary

Move onSubmit out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)

Depends on D3795

Test Plan
  1. Open ThreadSettingsModal
  2. Mess with the settings
  3. Hit save and make sure things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Branch
actuallylandapril21 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
23 lines

Diff 11818

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...