[native] Introduce `ColorSelector` component
ClosedPublic
Actions

Authored by • abosh on Apr 20 2022, 5:31 PM.

Details

Reviewers

atul

Commits

rCOMMf3d2d082e893: [native] Introduce `ColorSelector` component

Summary

Part of the first step in redesigning the ColorPicker component on native to match the ColorSelector component on web introduced by @atul. Depends on D3790

ColorSelector is a new component that will work with ColorSelectorButton to replace ColorPicker on native. This diff handles color layout, and adding onPress handling and active state functionality will be applied in later diffs.

See the full plan for the ColorPicker redesign in this Linear issue.

Test Plan

Tested on iOS 15.4 and works as expected:

Screen Shot 2022-04-20 at 10.27.59 AM.png (1×1 px, 593 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Apr 20 2022, 5:31 PM

Herald added subscribers: • benschac, • karol, • adrian and 2 others. · View Herald TranscriptApr 20 2022, 5:31 PM

• abosh edited the summary of this revision. (Show Details)Apr 20 2022, 5:31 PM

• abosh added 1 blocking reviewer(s): atul.

• abosh edited the test plan for this revision. (Show Details)

• abosh edited the summary of this revision. (Show Details)Apr 20 2022, 5:33 PM

• abosh edited the summary of this revision. (Show Details)

• abosh added a parent revision: D3790: [native] Introduce `ColorSelectorButton` component.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 20 2022, 5:36 PM

Harbormaster failed remote builds in B8374: Diff 11686!

Updated memoization to memoize array passed into style prop for the View in ColorSelectorButton.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 20 2022, 7:29 PM

Harbormaster failed remote builds in B8375: Diff 11687!

Harbormaster completed remote builds in B8375: Diff 11687.Apr 21 2022, 10:08 AM

• abosh requested review of this revision.Apr 21 2022, 10:08 AM

Looks like there's some sort of git issue here. Feel free to re-request review once the issues have been resolved!

native/components/color-selector-button.react.js
11–17	Looks like you have some sort of git issue here, you'll need to rebase or update this diff or something

This revision now requires changes to proceed.Apr 24 2022, 2:20 PM

fix git issues

Harbormaster completed remote builds in B8490: Diff 11836.Apr 24 2022, 3:41 PM

Looks good visually to me.

Something I noticed (outside the scope of this diff, but thanks to the provided screenshot) is that there's not great contrast between the modal and the view "behind it."

It would probably be a good idea to add some sort of outline or drop shadow to the Modal component to make that distinction clear.

It seems like it'd be another good starter task for you (@yayabosh). I'll create a Linear task and link it here.

edit: https://linear.app/comm/issue/ENG-1040/[native]-increase-contrast-between-modal-and-background-view