[web] [feat] [ENG-991] add show promote thread logic to web
ClosedPublic
Actions

Authored by • benschac on Apr 21 2022, 10:00 AM.

Details

Reviewers

atul
tomek
• jacek
• abosh

Commits

rCOMM0d0f869b628a: [web] [feat] [ENG-991] add show promote thread logic to web

Summary

add logic to promote chats that are promotable

no promote

Image 2022-04-21 at 1.04.21 PM.jpg (1×2 px, 261 KB)

promote

Image 2022-04-21 at 1.06.06 PM.jpg (1×2 px, 70 KB)

Test Plan

click on a sidebar that meets promotable criteria, promote option should be shown to you as an end user. Go to a non-promotable sidebar, it shouldn't have the promote option. logic was moved into the lib/hooks/promote-thread hook in a previous commit D3807. No new logic was introduced.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 21 2022, 10:00 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptApr 21 2022, 10:00 AM

• benschac edited the summary of this revision. (Show Details)Apr 21 2022, 10:06 AM

• benschac edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8410: Diff 11735.Apr 21 2022, 10:06 AM

• benschac requested review of this revision.Apr 21 2022, 10:07 AM

• benschac added a parent revision: D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.Apr 21 2022, 10:07 AM

• benschac edited the test plan for this revision. (Show Details)

• benschac added a child revision: D3809: [web] [feat] [ENG-991] add modal prompt.Apr 21 2022, 10:10 AM

tomek accepted this revision.Apr 26 2022, 9:51 AM

This revision is now accepted and ready to land.Apr 26 2022, 9:51 AM

Closed by commit rCOMM0d0f869b628a: [web] [feat] [ENG-991] add show promote thread logic to web (authored by • benschac). · Explain WhyMay 4 2022, 4:41 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM0d0f869b628a: [web] [feat] [ENG-991] add show promote thread logic to web.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-menu.react.js

7 lines

Diff 12200

View Options

web/chat/thread-menu.react.js

// @flow		// @flow

import AsyncStorage from '@react-native-async-storage/async-storage';		import AsyncStorage from '@react-native-async-storage/async-storage';
import invariant from 'invariant';		import invariant from 'invariant';
import { Platform } from 'react-native';		import { Platform } from 'react-native';
import Orientation from 'react-native-orientation-locker';		import Orientation from 'react-native-orientation-locker';
import { createMigrate, createTransform } from 'redux-persist';		import { createMigrate, createTransform } from 'redux-persist';
import type { Transform } from 'redux-persist/es/types.js';		import type { Transform } from 'redux-persist/es/types.js';

import { highestLocalIDSelector } from 'lib/selectors/local-id-selectors.js';		import { highestLocalIDSelector } from 'lib/selectors/local-id-selectors.js';
import { inconsistencyResponsesToReports } from 'lib/shared/report-utils.js';		import { inconsistencyResponsesToReports } from 'lib/shared/report-utils.js';
import {		import {
getContainingThreadID,		getContainingThreadID,
getCommunity,		getCommunity,
} from 'lib/shared/thread-utils.js';		} from 'lib/shared/thread-utils.js';
import {		import { DEPRECATED_unshimMessageStore } from 'lib/shared/unshim-utils.js';
DEPRECATED_unshimMessageStore,
unshimFunc,
} from 'lib/shared/unshim-utils.js';
import { defaultEnabledApps } from 'lib/types/enabled-apps.js';		import { defaultEnabledApps } from 'lib/types/enabled-apps.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js';		import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import {		import {
type LocalMessageInfo,		type LocalMessageInfo,
type MessageStore,		type MessageStore,
messageTypes,		messageTypes,
type ClientDBMessageStoreOperation,		type ClientDBMessageStoreOperation,
type ClientDBMessageInfo,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultConnectionInfo } from 'lib/types/socket-types.js';		import { defaultConnectionInfo } from 'lib/types/socket-types.js';
import {		import { translateRawMessageInfoToClientDBMessageInfo } from 'lib/utils/message-ops-utils.js';
translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo,
} from 'lib/utils/message-ops-utils.js';
import { defaultNotifPermissionAlertInfo } from 'lib/utils/push-alerts.js';		import { defaultNotifPermissionAlertInfo } from 'lib/utils/push-alerts.js';
import { convertThreadStoreOperationsToClientDBOperations } from 'lib/utils/thread-ops-utils.js';		import { convertThreadStoreOperationsToClientDBOperations } from 'lib/utils/thread-ops-utils.js';

import { migrateThreadStoreForEditThreadPermissions } from './edit-thread-permission-migration.js';		import { migrateThreadStoreForEditThreadPermissions } from './edit-thread-permission-migration.js';
import type { AppState } from './state-types.js';		import type { AppState } from './state-types.js';
		import { unshimClientDB } from './unshim-utils.js';
import { commCoreModule } from '../native-modules.js';		import { commCoreModule } from '../native-modules.js';
import { defaultDeviceCameraInfo } from '../types/camera.js';		import { defaultDeviceCameraInfo } from '../types/camera.js';
import { defaultGlobalThemeInfo } from '../types/themes.js';		import { defaultGlobalThemeInfo } from '../types/themes.js';
import { isTaskCancelledError } from '../utils/error-handling.js';		import { isTaskCancelledError } from '../utils/error-handling.js';

const migrations = {		const migrations = {
[1]: (state: AppState) => ({		[1]: (state: AppState) => ({
...state,		...state,
▲ Show 20 Lines • Show All 338 Lines • ▼ Show 20 Lines	try {
console.log(exception);		console.log(exception);
if (isTaskCancelledError(exception)) {		if (isTaskCancelledError(exception)) {
return state;		return state;
}		}
return { ...state, cookie: null };		return { ...state, cookie: null };
}		}
return state;		return state;
},		},
[32]: (state: AppState) => {		[32]: (state: AppState) => unshimClientDB(state, [messageTypes.MULTIMEDIA]),
// 1. Get messages from SQLite `messages` table.		[33]: (state: AppState) => unshimClientDB(state, [messageTypes.REACTION]),
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();

// 2. Translate `ClientDBMessageInfo`s to `RawMessageInfo`s.
const rawMessageInfos = clientDBMessageInfos.map(
translateClientDBMessageInfoToRawMessageInfo,
);

// 3. "Unshim" translated `RawMessageInfo`s.
const unshimmedRawMessageInfos = rawMessageInfos.map(messageInfo =>
unshimFunc(messageInfo, new Set([messageTypes.MULTIMEDIA])),
);

// 4. Translate unshimmed `RawMessageInfo`s back to `ClientDBMessageInfo`s.
const unshimmedClientDBMessageInfos = unshimmedRawMessageInfos.map(
translateRawMessageInfoToClientDBMessageInfo,
);

// 5. Construct `ClientDBMessageStoreOperation`s to clear SQLite `messages`
// table and repopulate with unshimmed `ClientDBMessageInfo`s.
const operations: $ReadOnlyArray<ClientDBMessageStoreOperation> = [
{
type: 'remove_all',
},
...unshimmedClientDBMessageInfos.map((message: ClientDBMessageInfo) => ({
type: 'replace',
payload: message,
})),
];

// 6. Try processing `ClientDBMessageStoreOperation`s and log out if
// `processMessageStoreOperationsSync(...)` throws an exception.
try {
commCoreModule.processMessageStoreOperationsSync(operations);
} catch (exception) {
console.log(exception);
return { ...state, cookie: null };
}

return state;
},
[33]: (state: AppState) => {
// 1. Get messages from SQLite `messages` table.
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();

// 2. Translate `ClientDBMessageInfo`s to `RawMessageInfo`s.
const rawMessageInfos = clientDBMessageInfos.map(
translateClientDBMessageInfoToRawMessageInfo,
);

// 3. "Unshim" translated `RawMessageInfo`s.
const unshimmedRawMessageInfos = rawMessageInfos.map(messageInfo =>
unshimFunc(messageInfo, new Set([messageTypes.REACTION])),
);

// 4. Translate unshimmed `RawMessageInfo`s back to `ClientDBMessageInfo`s.
const unshimmedClientDBMessageInfos = unshimmedRawMessageInfos.map(
translateRawMessageInfoToClientDBMessageInfo,
);

// 5. Construct `ClientDBMessageStoreOperation`s to clear SQLite `messages`
// table and repopulate with unshimmed `ClientDBMessageInfo`s.
const operations: $ReadOnlyArray<ClientDBMessageStoreOperation> = [
{
type: 'remove_all',
},
...unshimmedClientDBMessageInfos.map((message: ClientDBMessageInfo) => ({
type: 'replace',
payload: message,
})),
];

// 6. Try processing `ClientDBMessageStoreOperation`s and log out if
// `processMessageStoreOperationsSync(...)` throws an exception.
try {
commCoreModule.processMessageStoreOperationsSync(operations);
} catch (exception) {
console.log(exception);
return { ...state, cookie: null };
}

return state;
},
[34]: state => {		[34]: state => {
const { threadIDsToNotifIDs, ...stateSansThreadIDsToNotifIDs } = state;		const { threadIDsToNotifIDs, ...stateSansThreadIDsToNotifIDs } = state;
return stateSansThreadIDsToNotifIDs;		return stateSansThreadIDsToNotifIDs;
},		},
};		};

// After migration 31, we'll no longer want to persist `messageStore.messages`		// After migration 31, we'll no longer want to persist `messageStore.messages`
// via redux-persist. However, we DO want to continue persisting everything in		// via redux-persist. However, we DO want to continue persisting everything in
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines

[web] [feat] [ENG-991] add show promote thread logic to webClosedPublicActions