Page MenuHomePhabricator
Differential D3817

[lib] [refactor] [ENG-991] use nullish coalescing operator (?.) to simplify code
AbandonedPublicDraft
Actions

Authored by • benschac on Apr 22 2022, 11:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 11:10 PM
Unknown Object (File)
Sun, Apr 6, 10:53 AM
Unknown Object (File)
Fri, Apr 4, 6:15 PM
Unknown Object (File)
Thu, Apr 3, 6:49 AM
Unknown Object (File)
Thu, Apr 3, 1:16 AM
Unknown Object (File)
Thu, Apr 3, 1:16 AM
Unknown Object (File)
Mon, Mar 31, 9:12 PM
Unknown Object (File)
Sat, Mar 22, 3:58 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
atul
tomek
• jacek
• abosh
Summary

after moving this code to a hook, I thought this ternary code would make more sense with nullish coalescing

Test Plan

promote a thread and make sure it still works.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
hooks/
2 lines

Diff 11808

View Options

lib/hooks/promote-sidebar.react.js

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines default_action {
type = "forward" type = "forward"
forward { forward {
# ECS target group # ECS target group
target_group { target_group {
arn = aws_lb_target_group.identity_service_grpc.arn arn = aws_lb_target_group.identity_service_grpc.arn
weight = 1 weight = 1
} }
# Legacy EC2 Target # Legacy EC2 Target
target_group { dynamic "target_group" {
arn = data.aws_lb_target_group.identity_service_legacy_ec2.arn for_each = data.aws_lb_target_group.identity_service_legacy_ec2
content {
arn = target_group.value["arn"]
weight = 0 weight = 0
} }
} }
} }
}
lifecycle { lifecycle {
# Required only for existing resources to avoid plan difference # Required only for existing resources to avoid plan difference
ignore_changes = [default_action[0].forward[0].stickiness[0].duration] ignore_changes = [default_action[0].forward[0].stickiness[0].duration]
# Target group cannot be destroyed if it is used # Target group cannot be destroyed if it is used
replace_triggered_by = [aws_lb_target_group.identity_service_grpc] replace_triggered_by = [aws_lb_target_group.identity_service_grpc]
} }
} }
# SSL Certificate # SSL Certificate
data "aws_acm_certificate" "identity_service" { data "aws_acm_certificate" "identity_service" {
domain = "identity.commtechnologies.org" domain = "identity.commtechnologies.org"
statuses = ["ISSUED"] statuses = ["ISSUED"]
} }
# Legacy EC2 instance target # Legacy EC2 instance target
data "aws_lb_target_group" "identity_service_legacy_ec2" { data "aws_lb_target_group" "identity_service_legacy_ec2" {
# We don't have legacy EC2 services in staging
count = local.is_staging ? 0 : 1
name = "identity-service-tg" name = "identity-service-tg"
} }
# Required for Route53 DNS record # Required for Route53 DNS record
output "identity_service_load_balancer_dns_name" { output "identity_service_load_balancer_dns_name" {
value = aws_lb.identity_service.dns_name value = aws_lb.identity_service.dns_name
} }