[lib] [refactor] [ENG-991] use nullish coalescing operator (?.) to simplify code
AbandonedPublicDraft
Actions

Authored by • benschac on Apr 22 2022, 11:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 9:44 PM

	Unknown Object (File)
	Wed, Nov 27, 5:31 PM

	Unknown Object (File)
	Tue, Nov 19, 2:12 AM

	Unknown Object (File)
	Wed, Nov 13, 4:39 AM

	Unknown Object (File)
	Tue, Nov 5, 6:06 AM

	Unknown Object (File)
	Tue, Nov 5, 6:06 AM

	Unknown Object (File)
	Tue, Nov 5, 6:03 AM

	Unknown Object (File)
	Oct 25 2024, 7:10 AM

Subscribers

Details

Reviewers

atul
tomek
• jacek
• abosh

Summary

after moving this code to a hook, I thought this ternary code would make more sense with nullish coalescing

Test Plan

promote a thread and make sure it still works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 22 2022, 11:08 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptApr 22 2022, 11:08 AM

• benschac added a parent revision: D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.Apr 22 2022, 11:08 AM

• benschac abandoned this revision.Apr 22 2022, 11:12 AM

Harbormaster completed remote builds in B8469: Diff 11808.Apr 22 2022, 11:13 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

promote-sidebar.react.js

2 lines

Diff 11808

View Options

lib/hooks/promote-sidebar.react.js

[lib] [refactor] [ENG-991] use nullish coalescing operator (?.) to simplify codeAbandonedPublicDraftActions