Page MenuHomePhabricator

[web] [feat] [ENG-991] add show promote thread logic to web
ClosedPublic

Authored by benschac on Apr 21 2022, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 12:03 AM
Unknown Object (File)
Fri, Oct 25, 12:03 AM
Unknown Object (File)
Fri, Oct 25, 12:03 AM
Unknown Object (File)
Fri, Oct 25, 12:03 AM
Unknown Object (File)
Thu, Oct 17, 7:48 PM
Unknown Object (File)
Thu, Oct 17, 7:48 PM
Unknown Object (File)
Thu, Oct 17, 7:48 PM
Unknown Object (File)
Thu, Oct 17, 7:46 PM

Details

Summary

add logic to promote chats that are promotable

no promote

Image 2022-04-21 at 1.04.21 PM.jpg (1×2 px, 261 KB)

promote

Image 2022-04-21 at 1.06.06 PM.jpg (1×2 px, 70 KB)

Test Plan

click on a sidebar that meets promotable criteria, promote option should be shown to you as an end user. Go to a non-promotable sidebar, it shouldn't have the promote option. logic was moved into the lib/hooks/promote-thread hook in a previous commit D3807. No new logic was introduced.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 26 2022, 9:51 AM