This diff includes MessageOperationsUtilities files in XCode build system to trogger their compilation on iOS
Details
Details
The purpose of this diff is to trigger MessageOperationsUtilities compilation in iOS environment so that further diffs on its stack can use its functionality in NotificationService. Checking that the build is succesfull can be considered testing plan
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 1172–1176 ↗ | (On Diff #12493) | Why do we need to add these now? |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 1172–1176 ↗ | (On Diff #12493) | Without those flags we cannot compile code that directly instantiates folly::dynamic. |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 1172–1176 ↗ | (On Diff #12493) | Did CocoaPods automatically make this change, or did you make it manually? I noticed we have this in Pods-Comm.debug.xcconfig and Pods-Comm.release.xcconfig, but I don't remember adding it. So I suspect it was automatic, which makes me worry if your changes were manual that they may be automatically replaced cc @karol-bisztyga who introduced these flags for Pods-Comm.debug.xcconfig and Pods-Comm.release.xcconfig in D755 |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 1172–1176 ↗ | (On Diff #12493) | I added those flags manually via XCode GUI. What do you mean by 'those flags may be automatically replaced'? |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 1172–1176 ↗ | (On Diff #12493) | I confirmed with @karol-bisztyga that he introduced similar changes (in target Comm) manually via XCode GUI. |