Page MenuHomePhabricator
Differential D3991

introduce MessageOperationsUtilities files to XCode build system
ClosedPublic
Actions

Authored by marcin on May 10 2022, 4:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:14 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
Unknown Object (File)
Tue, Dec 17, 4:00 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol

Details

Reviewers
tomek
• karol
Commits
rCOMM7ca432b7c23b: introduce MessageOperationsUtilities files to XCode build system
Summary

This diff includes MessageOperationsUtilities files in XCode build system to trogger their compilation on iOS

Test Plan

The purpose of this diff is to trigger MessageOperationsUtilities compilation in iOS environment so that further diffs on its stack can use its functionality in NotificationService. Checking that the build is succesfull can be considered testing plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.May 10 2022, 4:33 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 4:33 AM
marcin added a parent revision: D3986: Implement function to store SQLite database entities from raw notification string in SQLite database.May 10 2022, 4:34 AM
Harbormaster completed remote builds in B8983: Diff 12493.May 10 2022, 4:51 AM
marcin requested review of this revision.May 10 2022, 4:51 AM
• karol resigned from this revision.May 10 2022, 6:24 AM
tomek accepted this revision.May 11 2022, 5:05 AM
tomek added inline comments.
native/ios/Comm.xcodeproj/project.pbxproj
1172–1176 ↗(On Diff #12493)

Why do we need to add these now?

This revision is now accepted and ready to land.May 11 2022, 5:05 AM
marcin added inline comments.May 11 2022, 5:10 AM
native/ios/Comm.xcodeproj/project.pbxproj
1172–1176 ↗(On Diff #12493)

Without those flags we cannot compile code that directly instantiates folly::dynamic.

marcin updated this revision to Diff 12555.May 11 2022, 8:14 AM

Retrigger CI

Harbormaster failed remote builds in B9017: Diff 12555!May 11 2022, 9:03 AM
Harbormaster completed remote builds in B9017: Diff 12555.May 11 2022, 10:30 AM
ashoat added a subscriber: • karol.May 11 2022, 6:19 PM
ashoat added inline comments.
native/ios/Comm.xcodeproj/project.pbxproj
1172–1176 ↗(On Diff #12493)

Did CocoaPods automatically make this change, or did you make it manually? I noticed we have this in Pods-Comm.debug.xcconfig and Pods-Comm.release.xcconfig, but I don't remember adding it. So I suspect it was automatic, which makes me worry if your changes were manual that they may be automatically replaced

cc @karol-bisztyga who introduced these flags for Pods-Comm.debug.xcconfig and Pods-Comm.release.xcconfig in D755

marcin added inline comments.May 16 2022, 2:52 AM
native/ios/Comm.xcodeproj/project.pbxproj
1172–1176 ↗(On Diff #12493)

I added those flags manually via XCode GUI. What do you mean by 'those flags may be automatically replaced'?

marcin added inline comments.May 16 2022, 4:14 AM
native/ios/Comm.xcodeproj/project.pbxproj
1172–1176 ↗(On Diff #12493)

I confirmed with @karol-bisztyga that he introduced similar changes (in target Comm) manually via XCode GUI.

marcin updated this revision to Diff 12718.May 16 2022, 4:57 AM

Rebase

Harbormaster failed remote builds in B9141: Diff 12718!May 16 2022, 4:58 AM
marcin updated this revision to Diff 12730.May 16 2022, 5:16 AM

Rebase

Harbormaster failed remote builds in B9153: Diff 12730!May 16 2022, 5:17 AM
ashoat added a comment.May 16 2022, 1:04 PM

Thanks for clarifying!

Harbormaster completed remote builds in B9153: Diff 12730.May 16 2022, 1:27 PM
marcin added a child revision: D4063: Use notification service on ios to store notification in sqlite.May 17 2022, 2:00 AM
marcin updated this revision to Diff 12801.May 17 2022, 2:55 AM

Rebase

Harbormaster failed remote builds in B9210: Diff 12801!May 17 2022, 2:55 AM
Harbormaster completed remote builds in B9210: Diff 12801.May 17 2022, 5:54 AM
marcin updated this revision to Diff 12849.May 18 2022, 2:10 AM

Rebase

Harbormaster failed remote builds in B9253: Diff 12849!May 18 2022, 2:11 AM
Harbormaster completed remote builds in B9253: Diff 12849.May 18 2022, 2:42 AM
marcin updated this revision to Diff 12867.May 18 2022, 4:09 AM

Rebase

Harbormaster failed remote builds in B9270: Diff 12867!May 18 2022, 4:10 AM
marcin updated this revision to Diff 12882.May 18 2022, 4:55 AM

Rebase

Harbormaster failed remote builds in B9282: Diff 12882!May 18 2022, 4:55 AM
Harbormaster completed remote builds in B9282: Diff 12882.May 18 2022, 7:07 AM
Harbormaster completed remote builds in B9270: Diff 12867.May 18 2022, 7:23 AM
marcin updated this revision to Diff 13033.May 24 2022, 12:43 AM

Rebase master

Harbormaster completed remote builds in B9413: Diff 13033.May 24 2022, 1:23 AM
marcin updated this revision to Diff 13943.Jun 29 2022, 4:22 AM

Rebase onto master. Move MessageOperationsUtilities to Persistent Storage Utilities

Harbormaster failed remote builds in B10089: Diff 13943!Jun 29 2022, 4:27 AM
marcin updated this revision to Diff 13949.Jun 29 2022, 4:36 AM

Rebase

marcin updated this revision to Diff 13950.Jun 29 2022, 5:05 AM

Add folly flags to compile in NotificationService

Harbormaster failed remote builds in B10095: Diff 13949!Jun 29 2022, 5:07 AM
Harbormaster completed remote builds in B10096: Diff 13950.Jun 29 2022, 5:17 AM
Closed by commit rCOMM7ca432b7c23b: introduce MessageOperationsUtilities files to XCode build system (authored by marcin). · Explain WhyJun 29 2022, 5:22 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM7ca432b7c23b: introduce MessageOperationsUtilities files to XCode build system.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
58 lines

Diff 13957

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...