Update clang-format to v1.8.0 since 1.7.0 does not work on Intel
Details
Details
Check that yarn clang-format-all works on Intel mac
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/ios/Comm/CommSecureStore.mm | ||
|---|---|---|
| 31 ↗ | (On Diff #12806) | It's really interesting why the code that isn't properly formatted happened to be landed |
| yarn.lock | ||
|---|---|---|
| 15692 ↗ | (On Diff #12806) | (This is because of https://github.com/CommE2E/comm/commit/33f1104ae4759296ae9f7cc1601ee0602086e06a. I ran yarn cleaninstall before landing to make sure no changes showed up in working copy... but then when I ran yarn cleaninstall this morning the change removing shelljs@^0.8.5 showed up in my working copy. Pretty likely it was an omission on my end, but I'm typically pretty paranoid about running yarn cleaninstall once or twice to make sure yarn.lock has everything in it.) |