Page MenuHomePhabricator
Differential D4127

[services] Tunnelbroker - Add config ini file for dev-mode
ClosedPublic
Actions

Authored by • max on May 25 2022, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 11:31 AM
Unknown Object (File)
Tue, Apr 1, 12:22 AM
Unknown Object (File)
Mon, Mar 31, 12:41 PM
Unknown Object (File)
Sun, Mar 30, 10:58 PM
Unknown Object (File)
Sun, Mar 30, 10:20 PM
Unknown Object (File)
Fri, Mar 21, 12:55 AM
Unknown Object (File)
Wed, Mar 12, 12:55 AM
Unknown Object (File)
Feb 25 2025, 7:35 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMMe510794b0221: [services] Tunnelbroker - Add config ini file for dev-mode
Summary

Introducing configuration file for tunnelbroker dev-mode.
This configuration file will be loaded on the dev-mode service start.
To use the local rabbitMQ docker container we will use amqp.uri = amqp://comm:comm@rabbitmq connection string parameter which corresponds the docker-compose settings.

For the local dynamoDB (localstack) docker image *-test tables we are using the dynamodb table names section, which contains test table names.

Linear task: ENG-1101

Test Plan

Replace tunnelbroker.ini with tunnelbroker-dev.ini file and start the service yarn run-tunnelbroker-service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.May 25 2022, 12:46 PM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 25 2022, 12:46 PM
Harbormaster completed remote builds in B9474: Diff 13128.May 25 2022, 12:52 PM
• max updated this revision to Diff 13131.May 25 2022, 1:25 PM

Dev-mode config file path was added to the Constants.h.

Harbormaster completed remote builds in B9477: Diff 13131.May 25 2022, 1:32 PM
• max added a parent revision: D4126: [services] Tunnelbroker - Add yarn scripts for dev-mode.May 25 2022, 1:50 PM
• max published this revision for review.May 25 2022, 1:55 PM
• max edited the summary of this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max added a child revision: D4129: [services] Tunnelbroker - Change `ConfigManager.load()` to use config file path as a parameter.
• max added a child revision: D4131: [services] Tunnelbroker - Dev-mode environment variables in Docker.May 26 2022, 1:14 AM
• max removed a child revision: D4129: [services] Tunnelbroker - Change `ConfigManager.load()` to use config file path as a parameter.May 26 2022, 1:17 AM
tomek accepted this revision.May 26 2022, 3:43 AM
tomek added 1 blocking reviewer(s): • karol.

Adding @karol-bisztyga as blocking because he was introducing dev mode in other services.

• karol accepted this revision.May 26 2022, 5:03 AM
This revision is now accepted and ready to land.May 26 2022, 5:03 AM
Closed by commit rCOMMe510794b0221: [services] Tunnelbroker - Add config ini file for dev-mode (authored by • max). · Explain WhyMay 29 2022, 11:34 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMe510794b0221: [services] Tunnelbroker - Add config ini file for dev-mode.

Revision Contents
Changeset List

PathSize
services/
1 line
tunnelbroker/
src/
2 lines
11 lines

Diff 13193

View Options

services/docker-compose.yml

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

services/tunnelbroker/src/Constants.h

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

services/tunnelbroker/tunnelbroker-dev.ini

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines