Page MenuHomePhabricator
Differential D4131

[services] Tunnelbroker - Dev-mode environment variables in Docker
ClosedPublic
Actions

Authored by • max on May 26 2022, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 6:34 PM
Unknown Object (File)
Sat, Mar 29, 4:12 PM
Unknown Object (File)
Thu, Mar 27, 5:34 AM
Unknown Object (File)
Tue, Mar 25, 3:16 PM
Unknown Object (File)
Sun, Mar 9, 4:32 AM
Unknown Object (File)
Mar 3 2025, 7:12 PM
Unknown Object (File)
Feb 17 2025, 1:10 AM
Unknown Object (File)
Feb 17 2025, 1:10 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMMee197e1d6796: [services] Tunnelbroker - Dev-mode environment variables in Docker
Summary

To use the dev-mode inside the tunnelbroker we need to pass the COMM_SERVICES_DEV_MODE environment variable to the Docker container itself.

Linear task: ENG-1101

Test Plan

Run yarn run-tunnelbroker-service-dev-mode shows that the environment variable COMM_SERVICES_DEV_MODE is equal to 1.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.May 26 2022, 1:11 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 26 2022, 1:11 AM
• max added a parent revision: D4127: [services] Tunnelbroker - Add config ini file for dev-mode.May 26 2022, 1:14 AM
• max added a child revision: D4129: [services] Tunnelbroker - Change `ConfigManager.load()` to use config file path as a parameter.May 26 2022, 1:17 AM
Harbormaster completed remote builds in B9480: Diff 13134.May 26 2022, 1:17 AM
• max published this revision for review.May 26 2022, 1:21 AM
• max edited the summary of this revision. (Show Details)
• max added reviewers: • karol, tomek.
tomek accepted this revision.May 26 2022, 3:51 AM
tomek added 1 blocking reviewer(s): • karol.
• karol accepted this revision.May 26 2022, 5:55 AM
This revision is now accepted and ready to land.May 26 2022, 5:55 AM
Closed by commit rCOMMee197e1d6796: [services] Tunnelbroker - Dev-mode environment variables in Docker (authored by • max). · Explain WhyMay 29 2022, 11:36 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMee197e1d6796: [services] Tunnelbroker - Dev-mode environment variables in Docker.

Revision Contents
Changeset List

PathSize
services/
1 line
tunnelbroker/
3 lines

Diff 13194

View Options

services/docker-compose.yml

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

services/tunnelbroker/Dockerfile

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines