Page MenuHomePhabricator

[services] Remove `export` from the `package.json` scripts
ClosedPublic

Authored by max on May 26 2022, 6:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 9:19 AM
Unknown Object (File)
Mon, Oct 28, 3:03 AM
Unknown Object (File)
Mon, Oct 28, 3:02 AM
Unknown Object (File)
Mon, Oct 28, 3:01 AM
Unknown Object (File)
Mon, Oct 28, 2:51 AM
Unknown Object (File)
Wed, Oct 16, 8:43 AM
Unknown Object (File)
Wed, Oct 16, 8:43 AM
Unknown Object (File)
Wed, Oct 16, 8:43 AM

Details

Summary

At the D4126 @ashoat made a suggestion that we don't need to export in the services package.json file for the environment variable export to the bash scripts. We can remove it from the package.json scripts section.

Linear task: ENG-1197

Test Plan

Running yarn run-backup-service-dev-mode successfully passed COMM_SERVICES_DEV_MODE=1 environment variable to the binary inside the Docker container and executed the dev-mode.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max published this revision for review.May 26 2022, 6:08 AM
max edited the summary of this revision. (Show Details)
max edited the test plan for this revision. (Show Details)
max added reviewers: karol, tomek.
This revision is now accepted and ready to land.May 27 2022, 2:21 AM