Details

Reviewers

• karol
tomek

Commits

rCOMM4ae2e0d41997: [services] Tunnelbroker - Distinguish logging levels in dev-mode

Summary

Distinguish glog logging levels in production (default) and dev-mode.
For the production-mode we are using the minimal logging level 2 which corresponds to ERROR and FATAL messages.
For the dev-mode we're using the minimal logging level 0 which corresponds to showing all messages including INFO and WARNING.

Linear task: ENG-1102

Test Plan

Running yarn run-tunnelbroker-service prints only LOG(ERROR) and LOG(FATAL) messages.
Running yarn run-tunnelbroker-service-dev-mode prints LOG(INFO), LOG(WARNING), LOG(ERROR) and LOG(FATAL) messages.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.May 26 2022, 1:30 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 26 2022, 1:30 AM

• max added a parent revision: D4130: [services] Tunnelbroker - Load dev-mode config file on start.May 26 2022, 1:31 AM

• max edited the summary of this revision. (Show Details)May 26 2022, 1:35 AM

• max added reviewers: • karol, tomek.

Removing debug message.

• max published this revision for review.May 26 2022, 1:37 AM

Harbormaster completed remote builds in B9483: Diff 13137.May 26 2022, 1:38 AM

Fixed typo in function paramater.

Harbormaster completed remote builds in B9484: Diff 13138.May 26 2022, 1:45 AM

Harbormaster completed remote builds in B9485: Diff 13139.May 26 2022, 1:52 AM

tomek requested changes to this revision.May 26 2022, 4:06 AM

tomek added 1 blocking reviewer(s): • karol.

tomek added inline comments.

services/tunnelbroker/src/server.cpp
45 ↗	(On Diff #13139)	I think it is better to have warnings in production logs - they might be really useful when investigating bugs.

This revision now requires changes to proceed.May 26 2022, 4:06 AM

Change the production logging level to 1 (Warnings, Errors, Fatals).

• max marked an inline comment as done.May 26 2022, 5:19 AM

• max added inline comments.

services/tunnelbroker/src/server.cpp
45 ↗	(On Diff #13139)	I think it is better to have warnings in production logs - they might be really useful when investigating bugs. I've made this change.