[web] Introduce navigation arrows
ClosedPublic
Actions

Authored by tomek on May 26 2022, 8:36 AM.

Details

Reviewers

• jacek
atul
• benschac

Commits

rCOMMa585f909ca7a: [web] Introduce navigation arrows

Summary

Add arrows that allow users to navigate forward and backward in history.
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750

Test Plan

Open the app and check if arrows are displayed correctly.
Click right arrow - nothing should change.
Do a couple of tests by clicking left and right arrows, both in app and in the browser and by clicking some links. Everything should work.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 26 2022, 8:36 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 26 2022, 8:36 AM

tomek edited the summary of this revision. (Show Details)May 26 2022, 8:37 AM

Harbormaster completed remote builds in B9494: Diff 13148.May 26 2022, 8:43 AM

tomek requested review of this revision.May 26 2022, 8:43 AM

Code looks good to go

I know these buttons are in the Figma designs, but isn't it redundant to include our own back/forward navigation buttons when the browser already provides a UI for that? I probably should have asked before work started/diffs were put up.

Left a note here on Linear: https://linear.app/comm/issue/ENG-1193#comment-d05aa9fb

This revision is now accepted and ready to land.May 27 2022, 10:12 AM

@atul's point is a valid one... we might want to hide these behind a flag for now, and reenable it for macOS / Windows when we get around to building out the Electron app