Differential D4200

[lib] Destructure some properties in `reduceThreadInfos` to improve readability
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 3:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 2, 6:14 AM

	Unknown Object (File)
	Wed, Apr 2, 6:14 AM

	Unknown Object (File)
	Wed, Apr 2, 6:14 AM

	Unknown Object (File)
	Wed, Apr 2, 6:14 AM

	Unknown Object (File)
	Tue, Apr 1, 8:17 AM

	Unknown Object (File)
	Tue, Apr 1, 6:07 AM

	Unknown Object (File)
	Sat, Mar 29, 2:00 AM

	Unknown Object (File)
	Tue, Mar 18, 12:04 PM

Subscribers

Details

Reviewers

tomek
• jacek

Commits

rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability

Summary

Super minor noop refactor. Thought destructuring some properties would make things a little more readable.

Depends on D4198

Test Plan

Noop

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 2 2022, 3:56 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 3:56 PM

atul edited the summary of this revision. (Show Details)Jun 2 2022, 3:58 PM

atul added a parent revision: D4198: [lib] Rename `reduceThreadUpdates` => `generateOpsForThreadUpdates`.

Harbormaster completed remote builds in B9605: Diff 13315.Jun 2 2022, 4:10 PM

atul requested review of this revision.Jun 2 2022, 4:10 PM

tomek accepted this revision.Jun 3 2022, 3:02 AM

This revision is now accepted and ready to land.Jun 3 2022, 3:02 AM

cherrypick before landing

This revision was landed with ongoing or failed builds.Jun 8 2022, 5:38 AM

Closed by commit rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability.

Harbormaster completed remote builds in B9690: Diff 13430.Jun 8 2022, 5:44 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-reducer.js

12 lines

Diff 13315

lib/reducers/thread-reducer.js

	Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines		keyserverInfos: {
	: 'https://web.comm.app',			: 'https://web.comm.app',
	connection: { ...defaultConnectionInfo },			connection: { ...defaultConnectionInfo },
	lastCommunicatedPlatformDetails: null,			lastCommunicatedPlatformDetails: null,
	},			},
	},			},
	},			},
	threadActivityStore: {},			threadActivityStore: {},
	initialStateLoaded: false,			initialStateLoaded: false,
				integrityStore: { threadHashes: {}, threadHashingStatus: 'starting' },
	});			});

	export { defaultWebState };			export { defaultWebState };