Differential D4200

[lib] Destructure some properties in `reduceThreadInfos` to improve readability
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 3:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 12:04 PM

	Unknown Object (File)
	Sun, Mar 16, 9:54 AM

	Unknown Object (File)
	Sun, Mar 16, 9:54 AM

	Unknown Object (File)
	Sun, Mar 16, 9:54 AM

	Unknown Object (File)
	Sun, Mar 16, 9:48 AM

	Unknown Object (File)
	Sun, Mar 16, 9:43 AM

	Unknown Object (File)
	Sat, Mar 15, 9:29 PM

	Unknown Object (File)
	Wed, Mar 12, 6:50 AM

Subscribers

Details

Reviewers

tomek
• jacek

Commits

rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability

Summary

Super minor noop refactor. Thought destructuring some properties would make things a little more readable.

Depends on D4198

Test Plan

Noop

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 2 2022, 3:56 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 3:56 PM

atul edited the summary of this revision. (Show Details)Jun 2 2022, 3:58 PM

atul added a parent revision: D4198: [lib] Rename `reduceThreadUpdates` => `generateOpsForThreadUpdates`.

Harbormaster completed remote builds in B9605: Diff 13315.Jun 2 2022, 4:10 PM

atul requested review of this revision.Jun 2 2022, 4:10 PM

tomek accepted this revision.Jun 3 2022, 3:02 AM

This revision is now accepted and ready to land.Jun 3 2022, 3:02 AM

cherrypick before landing

This revision was landed with ongoing or failed builds.Jun 8 2022, 5:38 AM

Closed by commit rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0b7b96118692: [lib] Destructure some properties in `reduceThreadInfos` to improve readability.

Harbormaster completed remote builds in B9690: Diff 13430.Jun 8 2022, 5:44 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-reducer.js

12 lines

Diff 13431

lib/reducers/thread-reducer.js

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines		"dependencies": {
	"firebase-admin": "^10.1.0",			"firebase-admin": "^10.1.0",
	"geoip-lite": "^1.4.0",			"geoip-lite": "^1.4.0",
	"invariant": "^2.2.4",			"invariant": "^2.2.4",
	"landing": "0.0.1",			"landing": "0.0.1",
	"lib": "0.0.1",			"lib": "0.0.1",
	"lodash": "^4.17.21",			"lodash": "^4.17.21",
	"multer": "^1.4.1",			"multer": "^1.4.1",
	"mysql2": "^1.5.1",			"mysql2": "^1.5.1",
	"node-schedule": "^1.3.0",			"node-schedule": "^2.1.0",
	"nodemailer": "^6.6.1",			"nodemailer": "^6.6.1",
	"react": "17.0.2",			"react": "17.0.2",
	"react-dom": "17.0.2",			"react-dom": "17.0.2",
	"react-html-email": "^3.0.0",			"react-html-email": "^3.0.0",
	"react-redux": "^7.1.1",			"react-redux": "^7.1.1",
	"react-router": "^5.2.0",			"react-router": "^5.2.0",
	"redis": "^3.1.1",			"redis": "^3.1.1",
	"redux": "^4.0.4",			"redux": "^4.0.4",
	Show All 29 Lines